Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Ship Fenix x86_64 builds #445

Closed
cpeterso opened this issue Feb 12, 2019 · 6 comments
Closed

Ship Fenix x86_64 builds #445

cpeterso opened this issue Feb 12, 2019 · 6 comments
Labels
eng:release Release Engineering

Comments

@cpeterso
Copy link

cpeterso commented Feb 12, 2019

We need to publish 64-bit builds to the Google Play Store before Google's August 1 deadline requiring 64-bit support (for apps that include native code).

https://android-developers.googleblog.com/2019/01/get-your-apps-ready-for-64-bit.html

It looks like Fenix is only shipping 32-bit ARMv7 and x86 builds:

fenix/.taskcluster.yml

Lines 92 to 93 in 19dd468

--apk arm/release/app-arm-release-unsigned.apk \
--apk x86/release/app-x86-release-unsigned.apk \

GeckoView publishes x86_64 builds in Maven, but we haven't actually shipped x86_64 builds to Fennec Nightly users yet. I'm working with Releng and Relman to ship x86_64 Fennec Nightly by the end of this week.

Fenix will need to ship x86_64 builds by Google's August 1 deadline (or take down our 32-bit x86 builds), but I recommend that you wait for Fennec Nightly users to dogfood x86_64 for a couple weeks before shipping x86_64 Fenix builds. The beginning of Fenix M3 (March) would probably be a good time.

(For shipping ARM64 Fenix builds, see issue #444.)

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added this to the Milestone 2 Backlog milestone Feb 12, 2019
@vesta0 vesta0 added size S 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Feb 12, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Feb 15, 2019

Will wait a few weeks for Fennec Nightly users to test this. 1.5% of Fennec users have it.

@cpeterso
Copy link
Author

cpeterso commented Mar 3, 2019

@vesta0 and @pocmo - Fennec Nightly has been shipping x86_64 builds since February 13 (Fennec bug 1505538) without any big problems. Thus Fenix and R-B can start shipping x86 and x86_64 builds whenever you like, so I am removing this issue's blocked label.

Admittedly, we don't have many x86 or x86_64 Fennec Nightly users. Based on telemetry, Fennec Nightly's architecture split is:

71.24% ARM64
27.95% ARM 32-bit
 0.76% x86 32-bit
 0.04% x86_64

@cpeterso cpeterso removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Mar 3, 2019
@cpeterso
Copy link
Author

cpeterso commented Mar 5, 2019

Fenix x86_64 will need support from Application Services:
mozilla/application-services#426

@cpeterso cpeterso changed the title Ship x86_64 builds Ship Fenix x86_64 builds Mar 5, 2019
@vesta0 vesta0 removed the size S label Mar 27, 2019
@vesta0 vesta0 added 🚢 AS dependent P1 Current sprint labels Mar 29, 2019
@vesta0 vesta0 added the eng:release Release Engineering label Apr 3, 2019
@vesta0 vesta0 added P2 Upcoming release and removed P1 Current sprint labels Apr 17, 2019
@vesta0 vesta0 modified the milestones: MVP Backlog, Post-MVP Backlog Apr 18, 2019
@vesta0 vesta0 added the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label Apr 18, 2019
@cpeterso cpeterso removed the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label Apr 19, 2019
@cpeterso
Copy link
Author

cpeterso commented Apr 19, 2019

Removing Needs GV work label because x86_64 builds of GV already exist. Fennec has been testing x86_64 in Nightly and Beta without any reports of problems (though there are very few x86_64 Fennec users).

https://maven.mozilla.org/?prefix=maven2/org/mozilla/geckoview/geckoview-nightly-x86_64/

@kbrosnan
Copy link
Contributor

This is done.

@ghost ghost removed the P2 Upcoming release label Apr 29, 2019
@cpeterso
Copy link
Author

@kbrosnan When were Fenix x86_64 builds first available? I don't see them in the Google Play Store. For yesterday's Fenix and Reference Browser releases (both version 1.0.1918), I see only APKs for armeabi-v7a, arm64-v8a, and x86. Maybe we're building the x86_64 APKs but not uploading them to the Play Store yet?

@cpeterso cpeterso reopened this Apr 30, 2019
st3fan added a commit that referenced this issue May 25, 2019
st3fan added a commit that referenced this issue May 25, 2019
st3fan added a commit that referenced this issue May 27, 2019
st3fan added a commit that referenced this issue May 27, 2019
st3fan added a commit that referenced this issue May 27, 2019
st3fan added a commit that referenced this issue May 28, 2019
st3fan added a commit that referenced this issue May 28, 2019
st3fan added a commit that referenced this issue May 28, 2019
@ghost ghost closed this as completed in ff5eca1 May 29, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:release Release Engineering
Projects
None yet
Development

No branches or pull requests

3 participants