Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Commit

Permalink
Fixes #445 - Ship Fenix x86_64 builds
Browse files Browse the repository at this point in the history
  • Loading branch information
st3fan committed May 25, 2019
1 parent 884da93 commit 09a7f90
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 8 deletions.
13 changes: 10 additions & 3 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -71,16 +71,22 @@ android {
abiFilter "armeabi-v7a"
}
}
aarch64 {
dimension "abi"
ndk {
abiFilter "arm64-v8a"
}
}
x86 {
dimension "abi"
ndk {
abiFilter "x86"
}
}
aarch64 {
x86_64 {
dimension "abi"
ndk {
abiFilter "arm64-v8a"
abiFilter "x86_64"
}
}
}
Expand Down Expand Up @@ -319,8 +325,9 @@ dependencies {
implementation Deps.mozilla_lib_fetch_httpurlconnection

armImplementation Gecko.geckoview_beta_arm
x86Implementation Gecko.geckoview_beta_x86
aarch64Implementation Gecko.geckoview_beta_aarch64
x86Implementation Gecko.geckoview_beta_x86
x86_64Implementation Gecko.geckoview_beta_x86_64

implementation Deps.androidx_legacy
implementation Deps.androidx_preference
Expand Down
2 changes: 1 addition & 1 deletion automation/taskcluster/decision_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def pr_or_push(is_push):


def release(track, is_staging, version_name):
architectures = ['x86', 'arm', 'aarch64']
architectures = ['x86', 'x86_64', 'arm', 'aarch64']
apk_paths = ["public/target.{}.apk".format(arch) for arch in architectures]

build_tasks = {}
Expand Down
2 changes: 1 addition & 1 deletion automation/taskcluster/lib/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ def _craft_apk_full_path_from_variant(variant):
)


_SUPPORTED_ARCHITECTURES = ('aarch64', 'arm', 'x86')
_SUPPORTED_ARCHITECTURES = ('aarch64', 'arm', 'x86', 'x86_64')


def get_architecture_and_build_type_from_variant(variant):
Expand Down
8 changes: 5 additions & 3 deletions buildSrc/src/main/java/Gecko.kt
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,16 @@ object GeckoVersions {
@Suppress("MaxLineLength")
object Gecko {
const val geckoview_nightly_arm = "org.mozilla.geckoview:geckoview-nightly-armeabi-v7a:${GeckoVersions.nightly_version}"
const val geckoview_nightly_x86 = "org.mozilla.geckoview:geckoview-nightly-x86:${GeckoVersions.nightly_version}"
const val geckoview_nightly_aarch64 = "org.mozilla.geckoview:geckoview-nightly-arm64-v8a:${GeckoVersions.nightly_version}"
const val geckoview_nightly_x86 = "org.mozilla.geckoview:geckoview-nightly-x86:${GeckoVersions.nightly_version}"
const val geckoview_nightly_x86_64 = "org.mozilla.geckoview:geckoview-nightly-x86_64:${GeckoVersions.nightly_version}"

const val geckoview_beta_arm = "org.mozilla.geckoview:geckoview-beta-armeabi-v7a:${GeckoVersions.beta_version}"
const val geckoview_beta_x86 = "org.mozilla.geckoview:geckoview-beta-x86:${GeckoVersions.beta_version}"
const val geckoview_beta_aarch64 = "org.mozilla.geckoview:geckoview-beta-arm64-v8a:${GeckoVersions.beta_version}"
const val geckoview_beta_x86_64 = "org.mozilla.geckoview:geckoview-beta-x86_64:${GeckoVersions.beta_version}"

const val geckoview_release_arm = "org.mozilla.geckoview:geckoview-armeabi-v7a:${GeckoVersions.release_version}"
const val geckoview_release_x86 = "org.mozilla.geckoview:geckoview-x86:${GeckoVersions.release_version}"
const val geckoview_release_aarch64 = "org.mozilla.geckoview:geckoview-arm64-v8a:${GeckoVersions.release_version}"
const val geckoview_release_x86 = "org.mozilla.geckoview:geckoview-x86:${GeckoVersions.release_version}"
const val geckoview_release_x86_64 = "org.mozilla.geckoview:geckoview-x86_64:${GeckoVersions.release_version}"
}

0 comments on commit 09a7f90

Please sign in to comment.