Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Install uBlock Origin #5630

Closed
1 task
vesta0 opened this issue Sep 27, 2019 · 25 comments · Fixed by #8064
Closed
1 task

Install uBlock Origin #5630

vesta0 opened this issue Sep 27, 2019 · 25 comments · Fixed by #8064

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Sep 27, 2019

User Story

As a user, I want to be able to install a popular Android WebExtension, such as uBlock Origin in Fenix, and be protected from unwanted ads and distractions.

Dependencies

A-C project board

Acceptance Criteria

  • I can choose to install uBlock Origin in Fenix
  • I can choose to un-install uBlock Origin in Fenix
  • I can see the # of blocked trackers and resources that have been blocked by uBlock origin

Design tasks

  • Add uBlock Origin as an install target under the Add-ons Manager page

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added the must label Sep 27, 2019
@vesta0 vesta0 added this to User Stories in A-C: WebExtensions and AddOns Sep 27, 2019
@vesta0 vesta0 removed this from Must in Fenix Q4 Feature Backlog Oct 3, 2019
@brampitoyo brampitoyo added this to Prioritized UX Backlog in Fenix Sprint Kanban Oct 16, 2019
@brampitoyo brampitoyo moved this from Prioritized UX Backlog to In Design in Fenix Sprint Kanban Oct 16, 2019
@brampitoyo
Copy link

Added design tasks.

@brampitoyo
Copy link

Updated design tasks to suit uBlock Origin.

@brampitoyo
Copy link

brampitoyo commented Oct 24, 2019

Progress report:

  • I’ve designed uBlock Origin as an installable target under Add-ons Settings
    • Add-ons like uBlock Origin has a “Disable” control, but other add-ons don’t have one (e.g. Video DownloadHelper)
    • Therefore, it seems like we want three different add-on states: not installed, installed (enabled) and installed (disabled) – so users can manually disable when the add-on doesn’t provide that control

@agi90
Copy link
Contributor

agi90 commented Oct 28, 2019

GeckoView meta-bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1582194

@Nahanokino
Copy link

Nahanokino commented Nov 3, 2019

How will it be possible to import rules into uBlock Origin if local file opening is inexplicably going to be removed from Fenix?

#4049

@andreicristianpetcu
Copy link

@Kakitoru sync or copy/paste

@brampitoyo
Copy link

Hi @Kakitoru, importing rules into uBlock Origin isn’t something I’ve thought of in the design, so thanks heaps for bringing it up.

Do you know if there are other features I’ve overlooked?

@brampitoyo
Copy link

Progress report:

  • Through iterating on the design, we now know that adding uBlock Origin (or any other add-on) should be done using a button (can either be a “+” icon, or “+ Add to Firefox)
  • After installing, we provide a toggle to enable/disable this add-on
  • This may help migration
    • For example, if you have uBlock Origin installed on Desktop or Fennec, Fenix can add uBlock Origin automatically, after you sign into your Firefox Accounts. All you need to do is enable it.
    • For maximum convenience, Fenix may even choose to enable uBlock Origin for you. In this case, we definitely want to let you know that Fenix did this in the background.

@andreicristianpetcu
Copy link

how can I test? config flags? special build? @brampitoyo

@brampitoyo
Copy link

Hi @andreicristianpetcu. As a UX designer in the team, my update talks about add-ons in terms of its experience and interface: user flow, mockups and design variations.

To my knowledge, our Engineering team is currently doing the groundwork to build it, and the actual support will only land in Fenix later this year.

We will definitely let you know when it’s available to test in the app!

@vesta0 vesta0 removed this from In Design in Fenix Sprint Kanban Dec 10, 2019
@ghost
Copy link

ghost commented Jan 5, 2020

Please add it , we need ublock origin

@jawz101
Copy link

jawz101 commented Jan 6, 2020

Having copied and pasted as well as synced uBO's settings into FFox for Android, sync doesn't work on Android Fennec. Even if it did work, the way uBlock Origin uses sync, it's per-device. I cannot sync one device to another. It also requires an initial upload before download works so the first step is to wipe out what is already in the sync storage. The only time it serves a purpose is if you uninstall uBlock and reinstall it in the same Firefox profile, in the same Firefox instance, on the same machine. Otherwise it just wipes itself out.

As for copy/paste, their built-in configuration editor is not too friendly. Sometimes it copies line numbers, adds extra line endings, won't let you delete lines easily when using touchscreen controls. The only thing that works reliably is exporting and importing from a file.

You'd also need the same for NoScript's export/import settings feature.

@andreicristianpetcu
Copy link

I'm not a Fenix dev but I would say uBO sync is a different story @jawz101

@jawz101
Copy link

jawz101 commented Jan 6, 2020

On November 3rd you suggested using sync or copy/paste in lieu of importing & exporting a backup of the config file. I was giving reasons why that is not too possible on mobile

@cadeyrn cadeyrn mentioned this issue Jan 7, 2020
2 tasks
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 3, 2020
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 3, 2020
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 3, 2020
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 4, 2020
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 4, 2020
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit that referenced this issue Feb 4, 2020
Closes #5630, #6069, #6092, #6091, #6124, and #6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
@gabrielluong gabrielluong reopened this Feb 4, 2020
@gabrielluong gabrielluong moved this from Q4 User Stories to In progress in A-C: WebExtensions and AddOns Feb 4, 2020
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Feb 4, 2020
@andreicristianpetcu
Copy link

@gabrielluong how can I test this? is there a special build or it should land in Nightly?

@lnicola

This comment has been minimized.

@cognition9144
Copy link

Looks like it's here: https://firefox-ci-tc.services.mozilla.com/tasks/b0F1rHGTSseQEfa2mamr-g#artifacts

@lnicola

This comment has been minimized.

@cognition9144
Copy link

But that's a debug build, right?

Sure. Nightly hasn't been built after that. It might be scheduled a few hours later. You can have a look at the debug build if you don't want to wait.

@ghost
Copy link

ghost commented Feb 4, 2020

Tested, it works.

@anisse
Copy link

anisse commented Feb 4, 2020

Same here. Thanks a lot for the work !

I found a few issues:

  • a minor one, when clicking on the uBlock panel, then the button to open the dashboard; it does open, but I need to go back first, it does not go on top.
  • I can reliably crash the browser by clicking on a list in uBo settings -> Lists. I've sent the crash reports, but since this isn't even a nightly build, I don't know if you'll see them. They don't appear in about:crashes, but it might be expected on Android.

Should I open new issues for those ?

@uBlock-user
Copy link

Can the extension be installed from an external site such as Github ?

example -- https://github.com/gorhill/uBlock/releases/tag/1.24.5b1

@csadilek csadilek moved this from In progress to Q4 User Stories in A-C: WebExtensions and AddOns Feb 4, 2020
@brampitoyo
Copy link

brampitoyo commented Feb 5, 2020

Hi everybody, we are working hard in collaboration with @gorhill to bring official uBlock Origin support to Fenix.

One more thing: to make the experience of using uBlock Origin even better (and other add-ons – in case we plan to support them in the future), it’s not enough to simply support an add-on. We also want to improve how add-ons are shown:

  • In Fennec, add-ons open in new tabs. Not only do they bring you out of the webpage you’re currently in, but if you change anything in the add-on, you must switch tabs to see it. We want to improve this.
  • Most add-ons are built for the desktop. They may open in doorhangers that have the width of a mobile device, but many elements aren’t big enough to be tappable. Ultimately, add-on developers will need to do the layout work; but we want to help them ‘responsify’ or optimise their design.

@ghost
Copy link

ghost commented Feb 5, 2020

good job. i will keep watch. and now fenix was my primary daily phone browser.

@lobontiumira
Copy link

Verified on the latest Nightly build from 2/5 with:

  • Samsung Galaxy Tab A6 (Android 5.1.1),
  • Nexus 5 (Android 6.0.1),
  • Huawei P9 Lite (Android 7),
  • Samsung Galaxy Tab S3 (Android 8),
  • OnePlus 5T (Android 9),
  • Google Pixel (Android 10).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

13 participants