-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8064 +/- ##
============================================
- Coverage 19.05% 18.68% -0.38%
Complexity 454 454
============================================
Files 306 314 +8
Lines 11959 12284 +325
Branches 1608 1635 +27
============================================
+ Hits 2279 2295 +16
- Misses 9489 9795 +306
- Partials 191 194 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a rogue fixme
and some a couple formatting nits 🙌
app/src/main/java/org/mozilla/fenix/addons/AddonDetailsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/addons/AddonPermissionsDetailsFragment.kt
Outdated
Show resolved
Hide resolved
Disabling the intermittent ui-test failures. Not related to this PR. |
app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarController.kt
Outdated
Show resolved
Hide resolved
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, metrics.yaml and metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, under data controls -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2 -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
Yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Will check-in at expiry -
Does the data collection use a third-party collection tool?
No
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147. Co-authored-by: Simon Chae <chaesmn@gmail.com> Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com> Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com> Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
I tested this on latest Firefox Preview Nightly, and although it mostly works, there are some problems. Where should I report them? Do you have any special bug tracker for uBlock Origin related issues, or should I just report them in issues in this repository? |
We currently have a label for Feature:WebExtension issues. I would check if this is already a reported issue. If not, feel free to create a new issue and we will get around to triaging it. |
Closes #5630, #6069, #6092, #6091, #6124, and #6147.
Pull Request checklist
After merge
To download an APK when reviewing a PR: