Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Provide add-on support #8064

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Feb 3, 2020

Closes #5630, #6069, #6092, #6091, #6124, and #6147.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #8064 into master will decrease coverage by 0.37%.
The diff coverage is 3.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8064      +/-   ##
============================================
- Coverage     19.05%   18.68%   -0.38%     
  Complexity      454      454              
============================================
  Files           306      314       +8     
  Lines         11959    12284     +325     
  Branches       1608     1635      +27     
============================================
+ Hits           2279     2295      +16     
- Misses         9489     9795     +306     
- Partials        191      194       +3
Impacted Files Coverage Δ Complexity Δ
...va/org/mozilla/fenix/components/metrics/Metrics.kt 21.23% <ø> (ø) 0 <0> (ø) ⬇️
...illa/fenix/addons/AddonInternalSettingsFragment.kt 0% <0%> (ø) 0 <0> (?)
...zilla/fenix/addons/NotYetSupportedAddonFragment.kt 0% <0%> (ø) 0 <0> (?)
...lla/fenix/components/toolbar/DefaultToolbarMenu.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/mozilla/fenix/addons/AddonDetailsFragment.kt 0% <0%> (ø) 0 <0> (?)
...ava/org/mozilla/fenix/settings/SettingsFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...illa/fenix/addons/InstalledAddonDetailsFragment.kt 0% <0%> (ø) 0 <0> (?)
...la/fenix/addons/AddonPermissionsDetailsFragment.kt 0% <0%> (ø) 0 <0> (?)
...c/main/java/org/mozilla/fenix/addons/Extensions.kt 0% <0%> (ø) 0 <0> (?)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 14.28% <0%> (-2.56%) 3 <0> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb71ce...099dedd. Read the comment docs.

Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a rogue fixme and some a couple formatting nits 🙌

@AaronMT
Copy link
Contributor

AaronMT commented Feb 3, 2020

Disabling the intermittent ui-test failures. Not related to this PR.

@gabrielluong
Copy link
Member Author

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often the user interacts with add-ons.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This will help us prioritize bugs and features related to add-ons based on user need.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • No current alternative methods.
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • Until 2020-09-01
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@gabrielluong gabrielluong added the needs:data-review PR is awaiting a data review label Feb 3, 2020
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, under data controls

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Has expiry

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Type 2

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Will check-in at expiry

  9. Does the data collection use a third-party collection tool?
    No

@gabrielluong gabrielluong changed the title Provide add-on support Provide add-on support. Feb 4, 2020
@gabrielluong gabrielluong changed the title Provide add-on support. Provide add-on support Feb 4, 2020
@gabrielluong gabrielluong changed the title Provide add-on support Provide add-on support 🎲 Feb 4, 2020
@gabrielluong gabrielluong changed the title Provide add-on support 🎲 Provide add-on support Feb 4, 2020
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
@gabrielluong gabrielluong merged commit 64a4a7f into mozilla-mobile:master Feb 4, 2020
@gabrielluong gabrielluong deleted the addons branch February 4, 2020 06:42
@lnicola lnicola mentioned this pull request Feb 4, 2020
1 task
@csadilek csadilek moved this from In progress to Done in A-C: WebExtensions and AddOns Feb 4, 2020
@filips123
Copy link

I tested this on latest Firefox Preview Nightly, and although it mostly works, there are some problems.

Where should I report them? Do you have any special bug tracker for uBlock Origin related issues, or should I just report them in issues in this repository?

@gabrielluong
Copy link
Member Author

I tested this on latest Firefox Preview Nightly, and although it mostly works, there are some problems.

Where should I report them? Do you have any special bug tracker for uBlock Origin related issues, or should I just report them in issues in this repository?

We currently have a label for Feature:WebExtension issues. I would check if this is already a reported issue. If not, feel free to create a new issue and we will get around to triaging it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Development

Successfully merging this pull request may close these issues.

Install uBlock Origin
7 participants