Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

WebExtensions settings #6091

Closed
2 tasks
vesta0 opened this issue Oct 17, 2019 · 5 comments
Closed
2 tasks

WebExtensions settings #6091

vesta0 opened this issue Oct 17, 2019 · 5 comments
Assignees
@brampitoyo
Labels
eng:qa:verified QA Verified Feature:WebExtensions
Projects
A-C: WebExtensions and AddOns

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Oct 17, 2019 •
edited by data-sync-user
Loading

User Story

As a user, I want to be able to access the settings for my installed WebExtensions, so I can customize my settings to match my preferences.

Dependencies

A-C project board

Acceptance Criteria

  • I can access and modify the settings for my installed WebExtensions
  • I can view details (description of the WebExtension, author, version, last updated, etc)
  • I can view the list of permissions I have granted to my WebExtensions
  • I can choose to allow an installed WebExtension in private browsing

Design tasks

  • Provide a way to access Settings for installed WebExtensions
    • Within Fenix Settings
    • Within the main interface of each installed WebExtensions

┆Issue is synchronized with this Jira Task
@vesta0 vesta0 added this to User Stories in A-C: WebExtensions and AddOns Oct 17, 2019
@vesta0 vesta0 changed the title Add-ons settings WebExtensions settings Oct 18, 2019
@vesta0 vesta0 added this to In Design in Fenix Sprint Kanban Oct 18, 2019
@brampitoyo
Copy link

Added design tasks.

@lime124 lime124 added the ux:l label Oct 22, 2019
@brampitoyo
Copy link

Progress report:

  • I’ve added a way to access uBlock Origin Settings
    • uBlock Origin is not optimised for mobile, so the UI will be hard to use
    • We need to talk to the developer to help adapt their UI for mobile layout
  • I’ve added a way to navigate to/from uBlock Origin Settings from within the Add-ons Manager
    • This seems to be all good and fairly straightforward.
  • When solved for uBlock Origin, we will also solve this problem for all other WebExtensions

@brampitoyo
Copy link

Progress report:

  • We’ve confirmed that auto-update is not modifiable. It’s always set to ON. This means that all add-ons will auto-update to the newest version that’s recommended by AMO.
  • We’ve also confirmed that all add-ons will run in both private and normal browsing
    • In the future, we may implement a control that make it possible for a specific add-on to turn OFF while in private browsing.

@vesta0 vesta0 removed this from In Design in Fenix Sprint Kanban Dec 10, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 3, 2020
@psymoon @Amejia481
@csadilek @gabrielluong
Provide add-on support
290d5d4 
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
@gabrielluong gabrielluong mentioned this issue Feb 3, 2020
Merged
4 tasks
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 3, 2020
@psymoon @Amejia481
@csadilek @gabrielluong
Provide add-on support
33e280c 
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 3, 2020
@psymoon @Amejia481
@csadilek @gabrielluong
Provide add-on support
47f8055 
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 4, 2020
@psymoon @Amejia481
@csadilek @gabrielluong
Provide add-on support
2eb839e 
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 4, 2020
@psymoon @Amejia481
@csadilek @gabrielluong
Provide add-on support
099dedd 
Closes mozilla-mobile#5630, mozilla-mobile#6069, mozilla-mobile#6092, mozilla-mobile#6091, mozilla-mobile#6124, and mozilla-mobile#6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
gabrielluong added a commit that referenced this issue Feb 4, 2020
@gabrielluong @psymoon
@Amejia481 @csadilek
Provide add-on support (#8064)
64a4a7f 
Closes #5630, #6069, #6092, #6091, #6124, and #6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Feb 4, 2020
@lobontiumira
Copy link

Verified that, as a user, I can:

  • access and modify the settings for uBlock Origin,
  • view details and description of the uBlock Origin's author, version, last updated, etc.,
  • view the list of permissions I have granted to uBlock Origin,
  • observe uBlock Origin run in both private and normal browsing.

Tested on the latest Nightly 200205 (#20360607) with One Plus 5T (Android 9), Google Pixel (Android 10), Samsung Galaxy Tab S3 (Android 8).

I will remove the eng:qa:needed label.
@brampitoyo can I close this?

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 5, 2020
@brampitoyo
Copy link

Yes. If it’s all verified and good, we can close this issue.

@brampitoyo brampitoyo moved this from Q4 User Stories to Done in A-C: WebExtensions and AddOns Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brampitoyo brampitoyo

Labels
eng:qa:verified QA Verified Feature:WebExtensions
Projects
A-C: WebExtensions and AddOns
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brampitoyo @lime124 @gabrielluong @lobontiumira @vesta0