This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
[Bug] Address bar's Google icon is on left side of address bar and overlaps text in RTL mode #6008
Labels
🐞 bug
Crashes, Something isn't working, ..
eng:qa:verified
QA Verified
eng:ready
Ready for engineering
Hacktoberfest
Highlights issues for Hacktoberfest contributors to help us!
help wanted
Help wanted from a contributor. More complex than good first issue.
🌐 L10N:RTL
Milestone
Comments
ekager
added
eng:ready
bors bot
pushed a commit
that referenced
this issue
Oct 15, 2019
6016: for #6008 - fix address bar layout on home fragment for RTL ◀ r=ekager a=cadeyrn  Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
bors bot
pushed a commit
that referenced
this issue
Oct 15, 2019
6016: for #6008 - fix address bar layout on home fragment for RTL ◀ r=ekager a=cadeyrn  6017: For #6011 - fixed truncated clipboard icon in RTL◀️ r=ekager a=cadeyrn  Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
bors bot
pushed a commit
that referenced
this issue
Oct 15, 2019
6016: for #6008 - fix address bar layout on home fragment for RTL ◀ r=ekager a=cadeyrn  Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
bors bot
pushed a commit
that referenced
this issue
Oct 19, 2019
5631: Closes #2441. Update LeakCanary to `2.0-beta-3` version r=ekager a=dector Updated LeakCanary. ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] ~~**Tests**: This PR includes thorough tests or an explanation of why it does not~~ - [x] ~~**Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not~~ - [x] ~~**Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features~~ ### After merge - [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture 6016: for #6008 - fix address bar layout on home fragment for RTL ◀ r=ekager a=cadeyrn  6020: For #1383: Fix updating description of close button on title change r=ekager a=mcarare 6022: Fixes #5030: Modified Dialog to match the others. r=ekager a=ValentinTimisica I changed the Dialog from permissions exceptions and used AlertDialog instead of Context.alert extension function. 6098: Added OnCheckListener to checkboxes: DeleteBrowsingDataFragment r=boek a=shangeethsivan Added OnCheckListener to all checkboxes ,when there are no items checked delete button will be disabled Closes #5465 Co-authored-by: Denys M <dector9@gmail.com> Co-authored-by: Sören Hentzschel <kontakt@agenedia.com> Co-authored-by: mcarare <mihai.carare.dev@gmail.com> Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro> Co-authored-by: Shangeeth Sivan <shangeeth@poshmark.com>
boek
pushed a commit
that referenced
this issue
Oct 21, 2019
sv-ohorvath
added
eng:qa:verified
|
Verified as fixed on Nightly 10/21 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to reproduce
Expected behavior
"Search or enter address" bar's Google icon should be on the right side of address bar and the "Search or enter address" should not overlap the Google icon.
Actual behavior
Here is a screenshot:
Device information
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: