This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
for #6008 - fix address bar layout on home fragment for RTL ◀ #6016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cadeyrn
commented
Oct 14, 2019
cadeyrn
commented
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
ekager
changed the title
|
bors r+ |
Codecov Report
@@ Coverage Diff @@
## master #6016 +/- ##
=========================================
Coverage 14.32% 14.32%
Complexity 326 326
=========================================
Files 261 261
Lines 10725 10725
Branches 1565 1565
=========================================
Hits 1536 1536
Misses 9065 9065
Partials 124 124Continue to review full report at Codecov.
|
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2019
6016: for #6008 - fix address bar layout on home fragment for RTL ◀ r=ekager a=cadeyrn  Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
Timed out |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2019
6016: for #6008 - fix address bar layout on home fragment for RTL ◀ r=ekager a=cadeyrn  6017: For #6011 - fixed truncated clipboard icon in RTL◀️ r=ekager a=cadeyrn  Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
Timed out (retrying...) |
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2019
6016: for #6008 - fix address bar layout on home fragment for RTL ◀ r=ekager a=cadeyrn  Co-authored-by: Sören Hentzschel <kontakt@agenedia.com>
Timed out |
|
bors r+ |
Merge conflict (retrying...) |
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2019
5631: Closes #2441. Update LeakCanary to `2.0-beta-3` version r=ekager a=dector Updated LeakCanary. ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] ~~**Tests**: This PR includes thorough tests or an explanation of why it does not~~ - [x] ~~**Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not~~ - [x] ~~**Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features~~ ### After merge - [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture 6016: for #6008 - fix address bar layout on home fragment for RTL ◀ r=ekager a=cadeyrn  6020: For #1383: Fix updating description of close button on title change r=ekager a=mcarare 6022: Fixes #5030: Modified Dialog to match the others. r=ekager a=ValentinTimisica I changed the Dialog from permissions exceptions and used AlertDialog instead of Context.alert extension function. 6098: Added OnCheckListener to checkboxes: DeleteBrowsingDataFragment r=boek a=shangeethsivan Added OnCheckListener to all checkboxes ,when there are no items checked delete button will be disabled Closes #5465 Co-authored-by: Denys M <dector9@gmail.com> Co-authored-by: Sören Hentzschel <kontakt@agenedia.com> Co-authored-by: mcarare <mihai.carare.dev@gmail.com> Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro> Co-authored-by: Shangeeth Sivan <shangeeth@poshmark.com>
ekager
added
the
pr:needs-landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.