This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
[Library update] Update LeakCanary to 2.0 #2441
Labels
Comments
|
Update. Seems like we need to wait for next release to use LeakCanary 2 with Flipper. Required API was added into LeakCanary after |
dector
added a commit
to dector/fenix
that referenced
this issue
May 12, 2019
4 tasks
dector
added a commit
to dector/fenix
that referenced
this issue
May 12, 2019
|
Hi @dector we have since removed Flipper from our project. Do you still want to handle updating the library? It should be easier now :) |
|
Awesome. :D Sure. I'll update my PR today / on weekend. |
dector
added a commit
to dector/fenix
that referenced
this issue
Sep 27, 2019
dector
added a commit
to dector/fenix
that referenced
this issue
Sep 27, 2019
dector
added a commit
to dector/fenix
that referenced
this issue
Sep 27, 2019
ekager
pushed a commit
to dector/fenix
that referenced
this issue
Oct 19, 2019
bors bot
pushed a commit
that referenced
this issue
Oct 19, 2019
5631: Closes #2441. Update LeakCanary to `2.0-beta-3` version r=ekager a=dector Updated LeakCanary. ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] ~~**Tests**: This PR includes thorough tests or an explanation of why it does not~~ - [x] ~~**Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not~~ - [x] ~~**Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features~~ ### After merge - [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture 6016: for #6008 - fix address bar layout on home fragment for RTL ◀ r=ekager a=cadeyrn  6020: For #1383: Fix updating description of close button on title change r=ekager a=mcarare 6022: Fixes #5030: Modified Dialog to match the others. r=ekager a=ValentinTimisica I changed the Dialog from permissions exceptions and used AlertDialog instead of Context.alert extension function. 6098: Added OnCheckListener to checkboxes: DeleteBrowsingDataFragment r=boek a=shangeethsivan Added OnCheckListener to all checkboxes ,when there are no items checked delete button will be disabled Closes #5465 Co-authored-by: Denys M <dector9@gmail.com> Co-authored-by: Sören Hentzschel <kontakt@agenedia.com> Co-authored-by: mcarare <mihai.carare.dev@gmail.com> Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro> Co-authored-by: Shangeeth Sivan <shangeeth@poshmark.com>
ekager
pushed a commit
to dector/fenix
that referenced
this issue
Oct 24, 2019
mcarare
pushed a commit
to mcarare/fenix
that referenced
this issue
Oct 29, 2019
data-sync-user
changed the title
data-sync-user
changed the title
kbrosnan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
🚧 🚧 🚧
Status: ON HOLD.
LeakCanary
2.0-alpha-1can't be used with Flipper yet. See this comment for details.🚧 🚧 🚧
What
Some time ago @pyricau released Leak Canary version
2.0-alpha-1. I think we should update to it.Why?
Version 2 has some very nice improvements, e.g.:
Acceptance Criteria (how do I know when I’m done?)
New LeakCanary functionality still detect memory leaks.
Usefull links
P.S. I'm preparing PR for Fenix project codebase. It'll be ready soon.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: