Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Show an undo snackbar when a pinned site is removed #7924

Closed
gabrielluong opened this issue Jan 25, 2020 · 13 comments · Fixed by #18869, nathanmkaya/fenix#108, C-EO/fenix#4 or fork-house/fenix#14
Closed

Show an undo snackbar when a pinned site is removed #7924

gabrielluong opened this issue Jan 25, 2020 · 13 comments · Fixed by #18869, nathanmkaya/fenix#108, C-EO/fenix#4 or fork-house/fenix#14
Assignees
@priyanka0906
Labels
eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue.
Projects
Top Sites
Milestone
109

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Jan 25, 2020 •
edited by data-sync-user

Acceptance criteria

  1. Have pinned site(s)
  2. Be on home screen
  3. Remove pinned site

Expected
See an undo snackbar with "Site removed" as the text and the pinned site is removed, with the ability to add it back when "undo" is pressed.

Actual
Pinned site is removed and no snackbar is shown.

Context:

@gabrielluong can we show an undo snackbar when someone removes a pinned site? Thanks!
#6759 (comment)

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added the Feature:Shortcuts Top Sites/Topsites on the Firefox home page label Jan 25, 2020
@gabrielluong gabrielluong self-assigned this Jan 25, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 25, 2020
@gabrielluong gabrielluong removed their assignment Jan 30, 2020
@mheubusch
Copy link
Contributor

Strings:
Site removed
UNDO

gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 7, 2020
@gabrielluong
For mozilla-mobile#7924 - Add strings for undo snackbar when removing…
8988f38 
… a top site
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Feb 7, 2020
@gabrielluong
For mozilla-mobile#7924 - Add strings for undo snackbar when removing…
215ee60 
… a top site
gabrielluong added a commit that referenced this issue Feb 7, 2020
@gabrielluong
For #7924 - Add strings for undo snackbar when removing a top site (#…
8a92e15 
…8225)
@gabrielluong gabrielluong self-assigned this Mar 10, 2020
@gabrielluong gabrielluong added this to In progress in Tabs/Top Sites Mar 11, 2020
@vesta0 vesta0 added this to In Progress in Fenix Sprint Kanban Mar 29, 2020
@vesta0 vesta0 removed this from In progress in Tabs/Top Sites Mar 31, 2020
@vesta0 vesta0 removed the needs:triage Issue needs triage label Mar 31, 2020
@gabrielluong gabrielluong removed their assignment Mar 31, 2020
@gabrielluong gabrielluong added the needs:triage Issue needs triage label Mar 31, 2020
@gabrielluong gabrielluong removed this from In Progress in Fenix Sprint Kanban Mar 31, 2020
@gabrielluong gabrielluong added this to Backlog in Top Sites Oct 19, 2020
@gabrielluong gabrielluong added this to Inbox in Engineering triage via automation Oct 19, 2020
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Oct 19, 2020
@gabrielluong
Copy link
Member Author

@topotropic I assume we still want to implement this?

@gabrielluong gabrielluong moved this from Inbox to Hershey Staging in Engineering triage Oct 19, 2020
@topotropic
Copy link

@topotropic I assume we still want to implement this?

Yes, thanks!

@gabrielluong gabrielluong added the pin Issues, features, improvements that are still valid label Jan 8, 2021
@eliserichards eliserichards added good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. Outreachy and removed pin Issues, features, improvements that are still valid labels Apr 2, 2021
@eliserichards
Copy link
Contributor

Tagging this with Outreachy, but note that it is more complicated than other features.

@priyanka0906
Copy link
Contributor

Tagging this with Outreachy, but note that it is more complicated than other features.

@eliserichards can I work on this

This was referenced Apr 7, 2021
Closed
Merged
@stale
Copy link

stale bot commented Oct 4, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 4, 2021
@stale stale bot closed this as completed Oct 12, 2021
Top Sites automation moved this from Backlog to Done Oct 12, 2021
@gabrielluong gabrielluong added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Dec 3, 2022
@gabrielluong gabrielluong reopened this Dec 3, 2022
@gabrielluong gabrielluong removed this from Hershey Staging in Engineering triage Dec 3, 2022
boek pushed a commit to priyanka0906/fenix that referenced this issue Dec 5, 2022
@boek
For mozilla-mobile#7924 - added an undo snackbar when a pinned site i…
d6b802f 
…s removed
boek pushed a commit to boek/fenix that referenced this issue Dec 5, 2022
@boek
For mozilla-mobile#7924 - added an undo snackbar when a pinned site i…
884085d 
…s removed
@github-actions github-actions bot mentioned this issue Dec 5, 2022
Closed
boek pushed a commit to priyanka0906/fenix that referenced this issue Dec 5, 2022
@boek
For mozilla-mobile#7924 - added an undo snackbar when a pinned site i…
54a3562 
…s removed
boek pushed a commit to priyanka0906/fenix that referenced this issue Dec 6, 2022
@boek
For mozilla-mobile#7924 - added an undo snackbar when a pinned site i…
01a043c 
…s removed
@mergify mergify bot closed this as completed in #18869 Dec 6, 2022
mergify bot pushed a commit that referenced this issue Dec 6, 2022
@mergify
For #7924 - added an undo snackbar when a pinned site is removed
d4303a2
@github-actions github-actions bot added this to the 109 milestone Dec 6, 2022
@github-actions github-actions bot reopened this Dec 6, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Dec 6, 2022
@SoftVision-LorandJanos
Copy link

Verified as implemented on the latest Nightly 109.0a1 (2022-12-07) build.
Device used: Google Pixel 4 (Android 13).
Closing the ticket as verified.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 7, 2022
@AdinaPetridean
Copy link

Also verified implemented on Beta 109.0b1 with Poco M4 Pro (Android 12).

This was referenced Jan 16, 2023
Merged
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mergify
[fenix] For mozilla-mobile/fenix#7924 - added an undo snackbar when a…
2491c0b 
… pinned site is removed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@priyanka0906 priyanka0906

Labels
eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue.
Projects
No open projects
Top Sites
  
Done
Milestone
109
8 participants
@topotropic @gabrielluong @mheubusch @vesta0 @eliserichards @SoftVision-LorandJanos @priyanka0906 @AdinaPetridean