Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Disabling TP in Strict mode doesn't work properly on Beta 4.3.1 #9948

Closed
AndiAJ opened this issue Apr 15, 2020 · 6 comments
Closed

[Bug]Disabling TP in Strict mode doesn't work properly on Beta 4.3.1 #9948

AndiAJ opened this issue Apr 15, 2020 · 6 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Settings Feature:TrackingProtection needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Apr 15, 2020

Prerequisites

Have tracking protection set to Strict

Steps to reproduce

  1. Navigate to https://mozilla.github.io/tracking-test/ads.html
  2. Disable tracking protection for this web
  3. Navigate to https://www.theverge.com/
  4. Disable tracking protection for this web site
  5. Tap the tracking protection shield and check the info shield

Expected behavior

For Step 2 a black cat should be displayed confirming the fact that TP is disabled.
For Step 5 some of the previously blocked options should be allowed

Actual behavior

It looks like even if the user disables tracking protection for a website Fenix Beta continues to block everything.

Device information

  • Android device:
    • Google Pixel 3a (Android 10)
    • Google Pixel 3 XL (Android 9)
    • Huawei Mate 20 Lite (Android 9)
    • OnePlus A3 (Android 6.0.1)

  • Fenix version: Fenix Beta 4.3.0-beta.1 from 4/14

Notes

✔️ Works on latest Nightly Build #21060608 from 4/15

Video Fenix Beta
20200415-110618

Video Fenix Nightly
20200415-110834

┆Issue is synchronized with this Jira Task

@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill Feature:TrackingProtection labels Apr 15, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 15, 2020
@Amejia481
Copy link
Contributor

To fix the issue we need some GeckoView work to happen, it can be tracked here https://bugzilla.mozilla.org/show_bug.cgi?id=1625585

@Amejia481 Amejia481 self-assigned this Apr 20, 2020
@Amejia481 Amejia481 added needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org 🙅 waiting Issues that are blocked or has dependencies that are not ready Feature:Settings labels Apr 20, 2020
@Amejia481
Copy link
Contributor

Amejia481 commented Apr 20, 2020

More details #9980

@liuche
Copy link
Contributor

liuche commented May 21, 2020

Looks like this might not be a GV problem - @fluffyemily how do we handle that handoff from GV to another Gecko team? This is something we'd like to have fixed for release. If you let me know the process, I'll also know for the future. (Do we wait for Ehsan and Johann to respond in bugzilla, and for how long? Do we need to re-prioritize to P1 if we want this for Fenix Release? etc)

@Amejia481
Copy link
Contributor

From the Expected behavior, 1 is working on nightly and 2 is partially as we still see some trackers being blocked as described in https://bugzilla.mozilla.org/show_bug.cgi?id=1625585#c4

Expected behavior

  1. For Step 2 a black cat should be displayed confirming the fact that TP is disabled.
  2. For Step 5 some of the previously blocked options should be allowed

@mcarare mcarare removed the needs:triage Issue needs triage label May 26, 2020
@liuche
Copy link
Contributor

liuche commented May 28, 2020

Hi @AndiAJ and @Amejia481 - I reached out to @englehardt who maintains this repo about the repo being out of date and not matching the ETP tracking. I'll reach out to him again to deprecate this page and redirect it to the correct testing page.

Can you also update testrail to reflect the updated site?

I believe this is the correct testing site https://senglehardt.com/test/trackingprotection/test_pages/
Can you retest @AndiAJ? Thank you!

@liuche liuche added the eng:qa:needed QA Needed label May 28, 2020
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented May 28, 2020

Hi @liuche , verified as fixed on the latest Beta 5.1.0-beta.2 from 5/27 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200528-124827

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Settings Feature:TrackingProtection needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Development

No branches or pull requests

4 participants