For #1063: Put tab tray behind a feature flag and hidden pref

[boek]

Fixes #1063

[codecov-io]

Codecov Report

Merging #10313 into master will decrease coverage by 0.02%.
The diff coverage is 6.25%.

@@             Coverage Diff              @@
##             master   #10313      +/-   ##
============================================
- Coverage     19.68%   19.66%   -0.03%     
  Complexity      600      600              
============================================
  Files           354      355       +1     
  Lines         14297    14328      +31     
  Branches       1916     1927      +11     
============================================
+ Hits           2814     2817       +3     
- Misses        11227    11255      +28     
  Partials        256      256              

Impacted Files	Coverage Δ	Complexity Δ
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...nix/components/toolbar/BrowserToolbarController.kt	64.44% <0.00%> (-1.47%)	0.00 <0.00> (ø)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...la/fenix/home/sessioncontrol/SessionControlView.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...mozilla/fenix/settings/SecretSettingsPreference.kt	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...ava/org/mozilla/fenix/settings/SettingsFragment.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt	75.32% <75.00%> (-0.01%)	30.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c95a6...5ef8c2a. Read the comment docs.

[darkwing]

Took an early peek at this quickly. Found something:

• The "Open Tabs" header displays when there are no open tabs and the pref is off. It think we still need the empty message and collections:

[darkwing]

I also cause a crash when I click the private browsing button on the top right of the home screen:

2020-04-30 13:43:17.267 21370-21370/org.mozilla.fenix.debug E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.mozilla.fenix.debug, PID: 21370
    java.lang.IllegalStateException: Fragment HomeFragment{34872ca} (8a74e32e-d0ba-4376-b768-89f196279993)} not attached to a context.
        at androidx.fragment.app.Fragment.requireContext(Fragment.java:805)
        at org.mozilla.fenix.home.HomeFragment$onCreateView$15.invoke(HomeFragment.kt:247)
        at org.mozilla.fenix.home.HomeFragment$onCreateView$15.invoke(HomeFragment.kt:111)
        at mozilla.components.lib.state.ext.ViewKt$consumeFrom$1.invokeSuspend(View.kt:37)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

This would be with the pref off and secret settings off.

[darkwing]

Code looks good, couldn't find any UI problems. R+! Excellent!

[cadeyrn]

@boek The comment is wrong (copied from PrivateBrowsingFragment, I guess?)