-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Move tabs from the home screen to a "tab tray" #1063
Comments
We have done much of what comment 0 talks about. Though the final bullet is not addressed. We still have a unified home/tabs screen. |
I thought Fennec had already solved this (along with pretty much every other Android browser I have tried), but there was the sessions idea that was supposed to be front and center (since removed) which testers were willing to try. #1487 and #1981 were solved in Fennec pretty elegantly, imo - and even sessions could be reintegrated with a scope like view like in Fennec, where top sites, bookmarks, history appear -- maybe a new scope for sessions could appear? |
related: #570 |
ok so what i'm reading is that this issue has been mostly addressed (per kevin's comment) there's the final bullet about the homescreen. let's put this as part of the homescreen design effort so we can take a look then. lmk if i missed something @ekager ! |
…ation from the home screen
…ation from the home screen
I noticed a few animation bugs with the current home screen that @boek thought might trouble us here too, and opened #6801 to track them. I think we could fix a lot of these bugs with one change if we added an animation to remove the current tabs before switching themes. Details in #6801 (comment). |
…ation from the home screen
…es to the BrowserFragment
… the tab tray - Adds interactor method for removing tabs - Wires up TabTrayFragment to remove deleted tab
… tab message with no tabs and no collections
* For #1063 - Adds feature flag and pref for new tab tray * For #1063 - Swaps add tab to tab tray button when newTabTray is enabled * For #1063 - Creates hidden preference to use new tab tray * For #1063 - Hides tabs on home screen when setting is enabled * For #1063 - Navigate to new tab tray from browser with setting enabled * For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections * For #1063 - Fixes crash when toggling to private mode on the home screen * For #1063 - combines both settings. Cleans up lint errors
@boek can I test this in Nightly? I saw a commit mentioning a feature flag. |
@andreicristianpetcu You have to use a debug build and then you can tap five times the Firefox logo on the "About" screen to enable the "Secret Settings" screen in the settings. |
@andreicristianpetcu Soon! I forgot to update the feature flag to include nightly |
It works in the latest nightly, FYI. |
Did some testing yesterday and today -- I'm glad it is behind a flag because I have a lot of feedback. :) See issues: #10369 - Tab tray buttons have bad contrast in dark theme with on screen buttons Other ideas: #10372 - Collections should be integrated into Tab Tray Issues that seem relevant again: #7913 - Tabbed tab switcher |
I tried to map out the new tab tray state machine following some of @yoasif 's comments in #10368 (comment) . But I've posted here since it seems to be really an omnibus issue. I think he's covered most of it, I find it very confusing. It differs somewhat from a conventional browser, what really strikes me is
If you like I can break these out under @yoasif's issues, or you can ignore me altogether, I think @yoasif has got it covered. |
I think that when user tap address bar it should show home screen. Only when he really starts interacting with text in address bar he should see search / suggestions screen. |
Hi all, I had a quick try of this new system this morning and I got a bit lost. I've since looked at the screen flow which @ekager shared in the OP and I now understand it better. I think what is confusing is that although this is closer to how Fennec works it's also sufficiently different to be confusing:
Also:
I like the thumbnails we see in the new Open Tabs view. Cheers 🙂 |
The tabs tray is not yet finished. That's why it's still behind a feature flag and a secret setting. :) Implementing the undo snackbar is #10332. |
Closing this issue since the initial tab tray that we are working on has been landed behind a feature flag. Follow ups to this feature are tracked on https://github.com/orgs/mozilla-mobile/projects/53. |
User Story
As a user, I want my tabs to be organized separately from the homescreen, so I can better manage my tabs and also make good use of my homescreen.
Acceptance Criteria
(Retain previous tab functionality)
-I can easily swipe a tab in order to delete it, for faster and more intuitive tab management.
-I can undo the deletion of a tab, in case of an accidental delete.
-I can still go through the save collections flow to create a new collection.
-Homescreen remains useful to me
I think a more traditional "tabs" fragment from browsing could make sense in Fenix.
Why/User Benefit/User Problem
UX
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: