Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Move tabs from the home screen to a "tab tray" #1063

Closed
Tracked by #6602
ekager opened this issue Mar 18, 2019 · 25 comments · Fixed by #10313
Closed
Tracked by #6602

Move tabs from the home screen to a "tab tray" #1063

ekager opened this issue Mar 18, 2019 · 25 comments · Fixed by #10313
Assignees
Labels
E8 Estimation Point: about 8 days Feature:Tabs

Comments

@ekager
Copy link
Contributor

ekager commented Mar 18, 2019

User Story

As a user, I want my tabs to be organized separately from the homescreen, so I can better manage my tabs and also make good use of my homescreen.

Acceptance Criteria

(Retain previous tab functionality)
-I can easily swipe a tab in order to delete it, for faster and more intuitive tab management.
-I can undo the deletion of a tab, in case of an accidental delete.
-I can still go through the save collections flow to create a new collection.
-Homescreen remains useful to me


I think a more traditional "tabs" fragment from browsing could make sense in Fenix.

Why/User Benefit/User Problem

  • As we heard in the UR study 2, some users can be confused by the tab/home button in the toolbar.
  • Additionally, in Wide, short tab previews give little useful visual info about tab's contents #1017 we are hearing from users that the thin tab slices aren't very useful for distinguishing tabs.
  • Lastly, from a navigation perspective, I think the UX can be confusing with the shared tabs / home view. That in order to view tabs from the browser you have to go home, what should happen when you press "back", etc.

UX

┆Issue is synchronized with this Jira Task

@ekager ekager added the needs:UX-feedback Needs UX Feedback label Mar 18, 2019
@vesta0 vesta0 added the P2 Upcoming release label Apr 2, 2019
@vesta0 vesta0 added this to the Backlog (After MVP) milestone Apr 2, 2019
@vesta0 vesta0 added the feature request 🌟 New functionality and improvements label Apr 2, 2019
@kbrosnan
Copy link
Contributor

We have done much of what comment 0 talks about. Though the final bullet is not addressed. We still have a unified home/tabs screen.

@yoasif
Copy link
Contributor

yoasif commented Apr 27, 2019

I thought Fennec had already solved this (along with pretty much every other Android browser I have tried), but there was the sessions idea that was supposed to be front and center (since removed) which testers were willing to try.

#1487 and #1981 were solved in Fennec pretty elegantly, imo - and even sessions could be reintegrated with a scope like view like in Fennec, where top sites, bookmarks, history appear -- maybe a new scope for sessions could appear?

@topotropic
Copy link

related: #570

@vesta0 vesta0 removed P2 Upcoming release labels Jul 2, 2019
@vesta0 vesta0 removed this from the Feature Backlog milestone Jul 26, 2019
@lime124
Copy link
Collaborator

lime124 commented Jul 26, 2019

ok so what i'm reading is that this issue has been mostly addressed (per kevin's comment) there's the final bullet about the homescreen. let's put this as part of the homescreen design effort so we can take a look then.

lmk if i missed something @ekager !

@lime124 lime124 removed the needs:UX-feedback Needs UX Feedback label Jul 26, 2019
@topotropic topotropic self-assigned this Oct 2, 2019
@vesta0 vesta0 mentioned this issue Nov 15, 2019
10 tasks
@boek boek changed the title Consider creating a traditional tabs fragment to access from browsing Move tabs from the home screen to a "tab tray" Nov 22, 2019
boek added a commit to boek/fenix that referenced this issue Nov 22, 2019
darkwing pushed a commit to darkwing/fenix that referenced this issue Nov 24, 2019
boek added a commit to boek/fenix that referenced this issue Nov 25, 2019
@severinrudie
Copy link
Contributor

I noticed a few animation bugs with the current home screen that @boek thought might trouble us here too, and opened #6801 to track them.

I think we could fix a lot of these bugs with one change if we added an animation to remove the current tabs before switching themes. Details in #6801 (comment).

boek added a commit to boek/fenix that referenced this issue Nov 26, 2019
boek added a commit to boek/fenix that referenced this issue Nov 26, 2019
boek added a commit to boek/fenix that referenced this issue Nov 26, 2019
boek added a commit to boek/fenix that referenced this issue Nov 26, 2019
… the tab tray

- Adds interactor method for removing tabs
- Wires up TabTrayFragment to remove deleted tab
boek added a commit to boek/fenix that referenced this issue Apr 30, 2020
boek added a commit to boek/fenix that referenced this issue Apr 30, 2020
… tab message with no tabs and no collections
boek added a commit to boek/fenix that referenced this issue Apr 30, 2020
darkwing pushed a commit that referenced this issue Apr 30, 2020
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
@andreicristianpetcu
Copy link

@boek can I test this in Nightly? I saw a commit mentioning a feature flag.

@cadeyrn
Copy link
Contributor

cadeyrn commented May 1, 2020

@andreicristianpetcu You have to use a debug build and then you can tap five times the Firefox logo on the "About" screen to enable the "Secret Settings" screen in the settings.

@boek
Copy link
Contributor

boek commented May 1, 2020

@andreicristianpetcu Soon! I forgot to update the feature flag to include nightly

@yoasif
Copy link
Contributor

yoasif commented May 2, 2020

It works in the latest nightly, FYI.

@yoasif
Copy link
Contributor

yoasif commented May 2, 2020

Did some testing yesterday and today -- I'm glad it is behind a flag because I have a lot of feedback. :)

See issues:

#10369 - Tab tray buttons have bad contrast in dark theme with on screen buttons
#10370 - Tab tray buttons have bad alignment
#10371 - It is too hard to save/move a selection of tabs into collections via tab tray

Other ideas:

#10372 - Collections should be integrated into Tab Tray
#10368 - Tapping new tab button should open a new tab instead of asking user to type url or search query
#10373 - Tab tray home button seems superfluous, since new tab could easily do this

Issues that seem relevant again:

#7913 - Tabbed tab switcher

@Cheap-Skate
Copy link

I tried to map out the new tab tray state machine following some of @yoasif 's comments in #10368 (comment) . But I've posted here since it seems to be really an omnibus issue. I think he's covered most of it, I find it very confusing. It differs somewhat from a conventional browser, what really strikes me is

  • can't access Home page (aka Top Sites) from within a tab. That's very unusual for a browser and it's something I desperately miss.
  • from the tab tray there are two unusual interim states not directly associated with a tab:- "Interim Home" and "Interim Search". As @yoasif says, in these interim states the tab has not yet been created, and they are a complex pair of states with rules for moving to/from them from the tabs tray and between them. The new tab is not actually created until I choose something from the Interim states. That's unusual:- normally the "new tab" button creates an empty tab and moves the user to its Home screen.
  • the Interim Search state looks identical to the normal tab Search state, but it's not. Pressing "Back" from Interim Search takes me to the tabs tray, but pressing "Back" from normal Search takes me to Web content. I find it confusing to have two identical Search screens, one within a tab and one not.
  • there are a few other rough edges:- I can navigate from Interim Home to Interim Search by tapping the URL bar, but then the Back button takes me to the tabs tray, not to Interim Search; and, tapping Back from the Interim Home state takes me out of the browser altogether (likely just a bug, I can file if you like).

If you like I can break these out under @yoasif's issues, or you can ignore me altogether, I think @yoasif has got it covered.

Screenshot 2020-05-03 at 12 45 39

Screenshot 2020-05-03 at 12 56 18

@Matth7878
Copy link

I think that when user tap address bar it should show home screen. Only when he really starts interacting with text in address bar he should see search / suggestions screen.

@madb1lly
Copy link

madb1lly commented May 4, 2020

Hi all,

I had a quick try of this new system this morning and I got a bit lost. I've since looked at the screen flow which @ekager shared in the OP and I now understand it better. I think what is confusing is that although this is closer to how Fennec works it's also sufficiently different to be confusing:

  • In Fennec home and new tab are the same, but in Fenix they are different and to access home and therefore Top Sites (which should be things I access frequently) it takes two taps, which is not an improvement.

Also:

  • Closing tab in the new Open Tabs view doesn't show an Undo dialogue (I assume this is a bug)

I like the thumbnails we see in the new Open Tabs view.

Cheers 🙂

@cadeyrn
Copy link
Contributor

cadeyrn commented May 4, 2020

Closing tab in the new Open Tabs view doesn't show an Undo dialogue (I assume this is a bug)

The tabs tray is not yet finished. That's why it's still behind a feature flag and a secret setting. :) Implementing the undo snackbar is #10332.

@gabrielluong
Copy link
Member

Closing this issue since the initial tab tray that we are working on has been landed behind a feature flag. Follow ups to this feature are tracked on https://github.com/orgs/mozilla-mobile/projects/53.

@boek boek added the E8 Estimation Point: about 8 days label May 8, 2020
@liuche liuche mentioned this issue May 19, 2020
32 tasks
@gabrielluong gabrielluong removed the needs:l10n Has strings that will require translation from the l10n team label May 30, 2020
@data-sync-user data-sync-user changed the title Move tabs from the home screen to a "tab tray" FNX2-16055 ⁃ Move tabs from the home screen to a "tab tray" Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16055 ⁃ Move tabs from the home screen to a "tab tray" FNX3-14038 ⁃ Move tabs from the home screen to a "tab tray" Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14038 ⁃ Move tabs from the home screen to a "tab tray" FNX-20 ⁃ Move tabs from the home screen to a "tab tray" Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-20 ⁃ Move tabs from the home screen to a "tab tray" FNX2-16055 ⁃ Move tabs from the home screen to a "tab tray" Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16055 ⁃ Move tabs from the home screen to a "tab tray" Move tabs from the home screen to a "tab tray" May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E8 Estimation Point: about 8 days Feature:Tabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.