This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Closes #1062 & Closes #1121: Restyles crash reporter view #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
sblatz
added
the
🙅 waiting
colintheshots
approved these changes
Mar 21, 2019
| import androidx.fragment.app.Fragment | ||
| import androidx.navigation.Navigation | ||
| import kotlinx.android.synthetic.main.fragment_crash_reporter.* | ||
| import mozilla.components.lib.crash.Crash | ||
| import org.jetbrains.anko.find |
There was a problem hiding this comment.
We're using anko for A/B testing layouts. It may be reasonable to use anko here, too. However, the Android framework finally became smart enough to auto-cast findViewById() calls in the past couple years. The convenience here is probably a wash and not really worth it anymore.
There was a problem hiding this comment.
Whoops! Meant to use findViewById here :)
sblatz
removed
the
🙅 waiting
…sh reporter view
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on getting this asset