For #1301: Add uri_count to metrics ping #1785
Conversation
ghost
assigned
| @@ -123,6 +123,19 @@ events: | |||
| notification_emails: | |||
| - fenix-core@mozilla.com | |||
| expires: "2020-03-01" | |||
| total_uri_count: | |||
There was a problem hiding this comment.
I wanted to put this under the metrics category, but this bug got in the way:
mozilla-mobile/android-components#2793
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Until 03/01/2020
|
| description: > | ||
| A counter of URIs visited by the user | ||
| send_in_pings: | ||
| - metrics |
There was a problem hiding this comment.
fly-by: please note that this is not sending data in the baseline ping, but rather in the metrics ping. I'm mentioning this since the PR title refers to the baseline ping. Please keep in mind that these pings, as documented, serve different purposes and have different schedules.
Any specific reason why you want to send this in the baseline ping anyway?
There was a problem hiding this comment.
@Dexterp37 Yeah, we noticed a couple of inconsistencies in the ticket. We're working on sorting it out!
There was a problem hiding this comment.
Ya, also @colintheshots to update the PR/issue/commit message of this to not say baseline ping.
app/metrics.yaml
Outdated
| total_uri_count: | ||
| type: counter | ||
| description: > | ||
| A counter of URIs visited by the user |
There was a problem hiding this comment.
So this is not unique URIs visited, just all URIs?
There was a problem hiding this comment.
Also specify if this is per-session
There was a problem hiding this comment.
This is intended to be per-session, including reloads of the same URL. The intent was that it work similarly to Focus. https://github.com/mozilla-mobile/focus-android/blob/master/docs/Telemetry.md#uri-count
There was a problem hiding this comment.
I'll add those details to the yaml.
colintheshots
changed the title
|
@liuche I updated the YAML. |
There was a problem hiding this comment.
LGTM
- Make sure you call subscribeToSessions :)
- We should think about where we are subscribing and the possible performance/ startup time hits from referencing engine related stuff (sessionmanager) from oncreate in homeactivity. Maybe we should do a follow up test for this
There was a problem hiding this comment.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes, in metrics.yaml -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, Fenix data controls -
If the request is for permanent data collection, is there someone who will monitor the data over time?**
Expires, fenix-core@ will monitor and determine renewal. -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **
Type 2, visits to web pages -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
Yes -
Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
No, has expiry -
Does the data collection use a third-party collection tool?
No, uses Glean SDK
Pull Request checklist