This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #21025: Set long term business-critical metrics as non-expiring #21038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request for Data Collection RenewalCc: @travis79
Never
These metrics are of fundamental features of Fenix, and have been determined to have critical and permanent business value. |
|
@mdboom We need an IC email in the |
Ah, gotcha. Looks like there have never been any permanent collections in Fenix before this so I missed that. It definitely shouldn't be me. Let's see what other reviewers think and I can make the necessary changes. |
|
We can use my email for notifications: erichards@mozilla.com |
Data Collection Renewal Review
Yes
Yes Additional notes: erichards@mozilla.com will be responsible for the permanently collected metrics. Resultdata-review+ Please don't forget to update the metrics.yaml |
mdboom
force-pushed
the
non-expire-metrics
branch
2 times, most recently
from
85b13a3
to
fd409d5
Compare
|
Great! This has been updated put |
|
This pull request has conflicts when rebasing. Could you fix it @mdboom? 🙏 |
mdboom
force-pushed
the
non-expire-metrics
branch
from
fd409d5
to
43a4bb4
Compare
|
I want to go over these with a fine-toothed comb. Planning on getting to it by the end of the week :) |
eliserichards
changed the title
|
This pull request has conflicts when rebasing. Could you fix it @mdboom? 🙏 |
mdboom
force-pushed
the
non-expire-metrics
branch
from
43a4bb4
to
d958212
Compare
mdboom
force-pushed
the
non-expire-metrics
branch
from
d958212
to
f153432
Compare
eliserichards
suggested changes
Oct 22, 2021
eliserichards
approved these changes
Oct 25, 2021
eliserichards
added
pr:approved
csadilek
reviewed
Oct 25, 2021
| data_sensitivity: | ||
| - interaction | ||
| notification_emails: | ||
| - android-probes@mozilla.com | ||
| - erichards@mozilla.com | ||
| expires: "2022-02-01" | ||
| - erichards@mozilla.com |
There was a problem hiding this comment.
nit: @eliserichards this is adding your email twice here in a few places :). e.g. line 494, 495.
6 tasks
|
@Mergifyio backport releases_v94.0.0 |
✅ Backports have been created
|
3 tasks
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this pull request
Mar 7, 2022
…non-expiring (mozilla-mobile#21038) * Set long term business-critical metrics as non-expiring. * Remove quotes around "never" Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #21025
This is based on the list created by @tdsmith:
https://docs.google.com/spreadsheets/d/1Duz3DcC1AP3GpMwNhBDr8WlGITCqVPv6kz6W4JOVDCk/edit?usp=sharing
This is partly in response to this month's incident where search ad click metrics were inadvertently expired and is an attempt to reduce the likelihood of such incidents in the future.
Pull Request checklist
To download an APK when reviewing a PR: