This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
No issue: fix glean metrics tests for expired metrics #20621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.private_search_suggestions in tests. These metrics have been expired and may be removed.
3 tasks
pocmo
approved these changes
Aug 2, 2021
Ugh, another one of those intermittent failures. I'll put up a separate PR for that and rerun this PR. |
uargh. :( |
This one is fighting really hard to not get merged.. |
eliserichards
added
the
pr:needs-landing-squashed
3 tasks
eliserichards
added a commit
to eliserichards/fenix
that referenced
this pull request
Aug 2, 2021
…#20621) * Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed. * Add ignores for performance metrics that have expired. * Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes. * Remove metrics controller from signature and remove in tests
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed. * Add ignores for performance metrics that have expired. * Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes. * Remove metrics controller from signature and remove in tests
czlucius
pushed a commit
to czlucius/fenix
that referenced
this pull request
Aug 20, 2021
…#20621) * Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed. * Add ignores for performance metrics that have expired. * Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes. * Remove metrics controller from signature and remove in tests
czlucius
pushed a commit
to czlucius/fenix
that referenced
this pull request
Aug 22, 2021
…#20621) * Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed. * Add ignores for performance metrics that have expired. * Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes. * Remove metrics controller from signature and remove in tests
eliserichards
added a commit
that referenced
this pull request
Aug 24, 2021
* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed. * Add ignores for performance metrics that have expired. * Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes. * Remove metrics controller from signature and remove in tests
eliserichards
added a commit
that referenced
this pull request
Aug 24, 2021
This reverts commit 3f0590d.
eliserichards
added a commit
to eliserichards/fenix
that referenced
this pull request
Aug 24, 2021
…#20621) * Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed. * Add ignores for performance metrics that have expired. * Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes. * Remove metrics controller from signature and remove in tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original probe renewal PR: #20517
Doc with details and Vesta's approval: https://docs.google.com/document/d/1NGlnTa9TPyTnd3ciUPbwujbITjkX8p8vJybXcZrrM2w/edit#
We have let these metrics expire (product decision, they may be removed later), and needed to remove them from the tests:
preferences.open_links_in_privatepreferences.private_search_suggestionsThe renewal for perf probes are being handled by the performance team, so adding an @ignore to the following tests for perf to remove when they are updated:
WHEN reporting THEN the values from the storageStats are accumulatedWHEN reporting THEN the query duration is measuredRemove the following probes entirely (cherry-picking from this PR because these will need to land together to fix all of the breaks)
tabs_tray.cfr.dismisstabs_tray.cfr.go_to_settingsPull Request checklist
To download an APK when reviewing a PR: