Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Renew/Remove metrics set to expire in v104 #25405

Merged
merged 2 commits into from
May 28, 2022

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented May 26, 2022

Request for Data Collection Renewal

Renew for 12 versions

Total: 12
———
events.default_browser_notif_tapped:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • never
  3. Why was the initial period of collection insufficient?

  • Default browser is one of our KPIs, so this metric will always be important

———
bookmarks_management.open:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • never
  3. Why was the initial period of collection insufficient?

    • Evergreen

———
tabs_tray.inactive_tabs_expanded:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 116
  3. Why was the initial period of collection insufficient?

    • Evaluating new feature

———
tabs_tray.inactive_tabs_collapsed:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 116
  3. Why was the initial period of collection insufficient?

    • Evaluating new feature

———
addons.open_addons_in_settings:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 116
  3. Why was the initial period of collection insufficient?

    • Prioritization of additional investment

———
addons.open_addon_in_toolbar_menu:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 116
  3. Why was the initial period of collection insufficient?

    • Prioritization of additional investment

———
addons.enabled_addons:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 116
  3. Why was the initial period of collection insufficient?

    • Prioritization of additional investment

———
engine_tab.kills:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 116
  3. Why was the initial period of collection insufficient?

    • Performance measure

———
engine_tab.kill_foreground_age:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 116
  3. Why was the initial period of collection insufficient?

    • Performance measure

———
engine_tab.kill_background_age:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 116
  3. Why was the initial period of collection insufficient?

    • Performance measure

———
engine_tab.foreground_metrics:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 116
  3. Why was the initial period of collection insufficient?

    • Performance measure

———

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Amejia481 Amejia481 added needs:data-review PR is awaiting a data review needs:review PRs that need to be reviewed labels May 26, 2022
@Amejia481 Amejia481 requested review from a team as code owners May 26, 2022 21:04
@rocketsroger
Copy link
Contributor

Request for Data Collection Renewal

Renew for 12 versions

Total: 12 ——— events.default_browser_notif_tapped:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Closes #19847: Add telemetry for the default browser notification #20311](https://github.com/mozilla-mobile/fenix/pull/20311)

2. When will this collection now expire?
   
   * never

3. Why was the initial period of collection insufficient?


* Default browser is one of our KPIs, so this metric will always be important

——— bookmarks_management.open:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Closes #18173: Add Telemetry When User Opens a Bookmark #18174](https://github.com/mozilla-mobile/fenix/pull/18174)

2. When will this collection now expire?
   
   * never

3. Why was the initial period of collection insufficient?
   
   * Evergreen

——— tabs_tray.inactive_tabs_expanded:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #20507 - Inactive tabs telemetry #20508 (comment)](https://github.com/mozilla-mobile/fenix/pull/20508#issuecomment-901336677)

2. When will this collection now expire?
   
   * 116

3. Why was the initial period of collection insufficient?
   
   * Evaluating new feature

——— tabs_tray.inactive_tabs_collapsed:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #20507 - Inactive tabs telemetry #20508 (comment)](https://github.com/mozilla-mobile/fenix/pull/20508#issuecomment-901336677)

2. When will this collection now expire?
   
   * 116

3. Why was the initial period of collection insufficient?
   
   * Evaluating new feature

——— addons.open_addons_in_settings:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #6174 - Add telemetry for WebExtensions #8318](https://github.com/mozilla-mobile/fenix/pull/8318)

2. When will this collection now expire?
   
   * 116

3. Why was the initial period of collection insufficient?
   
   * Prioritization of additional investment

——— addons.open_addon_in_toolbar_menu:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #6174 - Add telemetry for WebExtensions #8318](https://github.com/mozilla-mobile/fenix/pull/8318)

2. When will this collection now expire?
   
   * 116

3. Why was the initial period of collection insufficient?
   
   * Prioritization of additional investment

——— addons.enabled_addons:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #8920 - [Telemetry] Send add-on ids in a metrics ping #11080](https://github.com/mozilla-mobile/fenix/pull/11080)

2. When will this collection now expire?
   
   * 116

3. Why was the initial period of collection insufficient?
   
   * Prioritization of additional investment

——— engine_tab.kills:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Issue #12731: Collect telemetry about the content process of tabs getting killed. #17864](https://github.com/mozilla-mobile/fenix/pull/17864)

2. When will this collection now expire?
   
   * 116

3. Why was the initial period of collection insufficient?
   
   * Performance measure

——— engine_tab.kill_foreground_age:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Issue #12731: Collect telemetry about the content process of tabs getting killed. #17864](https://github.com/mozilla-mobile/fenix/pull/17864)

2. When will this collection now expire?
   
   * 116

3. Why was the initial period of collection insufficient?
   
   * Performance measure

——— engine_tab.kill_background_age:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Issue #12731: Collect telemetry about the content process of tabs getting killed. #17864](https://github.com/mozilla-mobile/fenix/pull/17864)

2. When will this collection now expire?
   
   * 116

3. Why was the initial period of collection insufficient?
   
   * Performance measure

——— engine_tab.foreground_metrics:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Introduce process lifecycle observer to collect metrics about tabs when app goes to foreground/background. #18747 (comment)](https://github.com/mozilla-mobile/fenix/pull/18747#issuecomment-815731764)

2. When will this collection now expire?
   
   * 116

3. Why was the initial period of collection insufficient?
   
   * Performance measure

———

Pull Request checklist

* [ ]  **Tests**: This PR includes thorough tests or an explanation of why it does not

* [ ]  **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not

* [ ]  **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features. In addition, it includes a screenshot of a successful [accessibility scan](https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor&hl=en_US) to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

1. click on Show All Checks,

2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,

3. click on the "Fenix - assemble" task, then click "Run Artifacts".

4. the APK links should be on the left side of the screen, named for each CPU architecture

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

@rocketsroger rocketsroger removed the needs:data-review PR is awaiting a data review label May 26, 2022
Copy link
Contributor

@MozillaNoah MozillaNoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Amejia481 Amejia481 removed the request for review from rocketsroger May 27, 2022 23:43
@Amejia481 Amejia481 added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels May 27, 2022
@mergify mergify bot merged commit c9240e2 into mozilla-mobile:main May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants