For #6174 - Add telemetry for WebExtensions #8318
Conversation
e0e39e0
to
a4dad5d
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
Codecov Report
@@ Coverage Diff @@
## master #8318 +/- ##
============================================
- Coverage 19.36% 18.92% -0.44%
+ Complexity 519 490 -29
============================================
Files 335 322 -13
Lines 13485 12925 -560
Branches 1793 1707 -86
============================================
- Hits 2611 2446 -165
+ Misses 10650 10275 -375
+ Partials 224 204 -20
Continue to review full report at Codecov.
|
Added a "do not land" for the time being. I intend on switching the the FEATURE_ADDON component flag to SUPPORT_WEBEXTENSIONS in Facts.toEvent(). |
Ready to be reviewed. Prior "do-not-land" was to correct the component name that was emitting the facts. mozilla-mobile/android-components#6109 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove all identifying (Names and id's) from the data collection for now and file a follow up issue for collecting that? It is going to have to be a bigger discussion
Hey @gabrielluong, is this ready for re-review? it still has a WIP label on it. Please ping if it's ready to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, metrics.yaml and metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, under data controls -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2 -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
Yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry -
Does the data collection use a third-party collection tool?
no
Fixes #6174. When an user interacts with an installed add-on in the browser menu, we emit a BrowserMenuFact with the add-on id. To cover the installed/removed/enabled/disabled add-ons, we do a metric ping using the list of enabled and installed add-ons that is emitted via WebExtensionFact.
Pull Request checklist
After merge
To download an APK when reviewing a PR: