Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix #26362: Use app:lineHeight to support API Level <= 27 #26364

Merged
merged 5 commits into from
Aug 8, 2022

Conversation

rudmannn
Copy link
Contributor

@rudmannn rudmannn commented Aug 8, 2022

Fixes #26362

Thanks @Mugurell, I am glad to take actions to fix the issues.

This pull request changes the usages of android:lineHeight to app:lineHeight. Now the line height should be consistent among API levels.

Screenshots at API Level 27

onboarding dialog
image

https only settings
image

custom search engine
image

Change android:lineHeight to app:lineHeight for incompatibilities at API Level <= 27
Change android:lineHeight to app:lineHeight for fixing incompatibilities in custom_search_engine
Change android:lineHeight to app:lineHeight in settings_https_only for incompatibilities at API Level <= 27
@rudmannn rudmannn requested review from a team as code owners August 8, 2022 12:19
@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@Mugurell
Copy link
Contributor

Mugurell commented Aug 8, 2022

Looks great! Thank for the investigation and fix!
To remove all traces about android:lineHeight can you also remove the suppressions from lint-baseline.txt?

Thank you for also organizing the work in multiple commits but probably just one Replace android:lineHeight with app:lineHeight to support lower api levels commit is enough. You could create a new commit for removing the now unneeded warning suppressions from suppressions from lint-baseline.txt if you'd like.

@rudmannn
Copy link
Contributor Author

rudmannn commented Aug 8, 2022

Looks great! Thank for the investigation and fix! To remove all traces about android:lineHeight can you also remove the suppressions from lint-baseline.txt?

Thank you for also organizing the work in multiple commits but probably just one Replace android:lineHeight with app:lineHeight to support lower api levels commit is enough. You could create a new commit for removing the now unneeded warning suppressions from suppressions from lint-baseline.txt if you'd like.

Please check the commit.

Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ✨

@Mugurell Mugurell mentioned this pull request Aug 8, 2022
4 tasks
@Mugurell Mugurell changed the title Fix #26362: android:lineHeight issues on API Level <= 27 Fix #26362: Use app:lineHeight to support API Level <= 27 Aug 8, 2022
@Mugurell Mugurell added the pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify] label Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android:lineHeight issues on API Level <= 27
3 participants