Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

android:lineHeight issues on API Level <= 27 #26362

Closed
Tracked by #26358
Mugurell opened this issue Aug 8, 2022 · 1 comment · Fixed by #26364, nathanmkaya/fenix#108 or fork-house/fenix#12
Closed
Tracked by #26358

android:lineHeight issues on API Level <= 27 #26362

Mugurell opened this issue Aug 8, 2022 · 1 comment · Fixed by #26364, nathanmkaya/fenix#108 or fork-house/fenix#12
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Aug 8, 2022

From @rudmannn:

I noticed the lint-baseline.xml for several times, and I can reproduce the issues induced by android:lineHeight.

android:lineHeight="16.sp"

You can see the differences in below.

onboarding dialog
API Level 29
2731659954434_ pic

API Level 27

2761659954682_ pic

https only

API Level 29
2741659954450_ pic

API Level 27
2771659954698_ pic

search engine

API Level 29
2751659954471_ pic

API Level 27

2781659954728_ pic

Note that you can simply change android:lineHeight to app:lineHeight and it works for API Level <= 27. I confirm that the issues have gone on my side.

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell added the good first issue Good for newcomers label Aug 8, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 8, 2022
@rudmannn
Copy link
Contributor

rudmannn commented Aug 8, 2022

Filed a pull request in #26364.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.