Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #27715: Allow FirefoxColors.copy to override some values #27716

Closed
wants to merge 1 commit into from
Closed

For #27715: Allow FirefoxColors.copy to override some values #27716

wants to merge 1 commit into from

Conversation

fice-t
Copy link
Contributor

@fice-t fice-t commented Nov 4, 2022 •
edited by gabrielluong
Loading

This helps to reduce theme color duplication, making it easier to see which parameters differ.

This also brings FirefoxColors closer to the upstream Compose Material Colors class.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #27715

@fice-t fice-t requested review from a team as code owners November 4, 2022 20:53
@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request 
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@fice-t
For mozilla-mobile#27715: Allow FirefoxColors.copy to override some v…
c4159d4 
…alues

This helps to reduce theme color duplication, making it easier to see
which parameters differ.

This also brings FirefoxColors closer to the upstream Compose Material
Colors class.
@gabrielluong gabrielluong self-requested a review November 4, 2022 21:09
@gabrielluong gabrielluong self-assigned this Nov 4, 2022
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label Nov 4, 2022
@MozillaNoah MozillaNoah self-assigned this Nov 9, 2022
@gabrielluong gabrielluong added pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Nov 9, 2022
@gabrielluong
Copy link
Member

Closing in place of #27771 which will the land the PR.

@fice-t fice-t deleted the color-copy branch November 11, 2022 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabrielluong gabrielluong gabrielluong approved these changes

Assignees

@gabrielluong gabrielluong

@MozillaNoah MozillaNoah

Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow FirefoxColors.copy to override some values
3 participants
@fice-t @gabrielluong @MozillaNoah