Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Allow FirefoxColors.copy to override some values #27715

Closed
fice-t opened this issue Nov 4, 2022 · 1 comment · Fixed by #27771, Leland-Takamine/fenix#159, fork-house/fenix#14 or nathanmkaya/fenix#108
Closed

Allow FirefoxColors.copy to override some values #27715

fice-t opened this issue Nov 4, 2022 · 1 comment · Fixed by #27771, Leland-Takamine/fenix#159, fork-house/fenix#14 or nathanmkaya/fenix#108
Assignees
@fice-t
Labels
needs:triage Issue needs triage
Milestone
108

Comments

@fice-t
Copy link
Contributor

fice-t commented Nov 4, 2022 •
edited by data-sync-user

This helps to reduce theme color duplication, making it easier to see which parameters differ.

┆Issue is synchronized with this Jira Task
┆Link To Issue: https://mozilla-hub.atlassian.net/browse/FNXV2-21932
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 4, 2022
@fice-t
Copy link
Contributor Author

fice-t commented Nov 4, 2022 •
edited

This also brings FirefoxColors closer to the upstream Compose Material
Colors class.

fice-t added a commit to fice-t/fenix that referenced this issue Nov 4, 2022
@fice-t
For mozilla-mobile#27715: Allow FirefoxColors.copy to override some v…
6fbb3b8 
…alues

This helps to reduce theme color duplication, making it easier to see
which parameters differ.

This also brings FenixColors closer to the upstream Compose Material
Colors class.
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 4, 2022
@github-actions github-actions bot mentioned this issue Nov 4, 2022
Closed
4 tasks
fice-t added a commit to fice-t/fenix that referenced this issue Nov 4, 2022
@fice-t
For mozilla-mobile#27715: Allow FirefoxColors.copy to override some v…
c4159d4 
…alues

This helps to reduce theme color duplication, making it easier to see
which parameters differ.

This also brings FirefoxColors closer to the upstream Compose Material
Colors class.
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Nov 9, 2022
@fice-t @gabrielluong
For mozilla-mobile#27715: Allow FirefoxColors.copy to override some v…
c9b1637 
…alues

This helps to reduce theme color duplication, making it easier to see
which parameters differ.

This also brings FirefoxColors closer to the upstream Compose Material
Colors class.
@github-actions github-actions bot mentioned this issue Nov 9, 2022
Merged
4 tasks
@gabrielluong gabrielluong removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 9, 2022
@mergify mergify bot closed this as completed in #27771 Nov 9, 2022
mergify bot pushed a commit that referenced this issue Nov 9, 2022
@fice-t @mergify
For #27715: Allow FirefoxColors.copy to override some values
df24580 
This helps to reduce theme color duplication, making it easier to see
which parameters differ.

This also brings FirefoxColors closer to the upstream Compose Material
Colors class.
@github-actions github-actions bot added this to the 108 milestone Nov 9, 2022
This was referenced Dec 13, 2022
Merged
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@fice-t @mergify
[fenix] For mozilla-mobile/fenix#27715: Allow FirefoxColors.copy to o…
f2c39d3 
…verride some values

This helps to reduce theme color duplication, making it easier to see
which parameters differ.

This also brings FirefoxColors closer to the upstream Compose Material
Colors class.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fice-t fice-t

Labels
needs:triage Issue needs triage
Projects
None yet
Milestone
108
2 participants
@gabrielluong @fice-t