Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

CI For #27715: Allow FirefoxColors.copy to override some values #27771

Merged
merged 2 commits into from
Nov 9, 2022
Merged

CI For #27715: Allow FirefoxColors.copy to override some values #27771

merged 2 commits into from
Nov 9, 2022

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Nov 9, 2022 •
edited by github-actions bot
Loading

This helps to reduce theme color duplication, making it easier to see which parameters differ.

This also brings FirefoxColors closer to the upstream Compose Material Colors class.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #27715

@fice-t @gabrielluong
For mozilla-mobile#27715: Allow FirefoxColors.copy to override some v…
c9b1637 
…alues

This helps to reduce theme color duplication, making it easier to see
which parameters differ.

This also brings FirefoxColors closer to the upstream Compose Material
Colors class.
@gabrielluong gabrielluong requested review from a team as code owners November 9, 2022 05:47
@gabrielluong
Copy link
Member Author

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2022

refresh

✅ Pull request refreshed

@jonalmeida jonalmeida added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Nov 9, 2022
@gabrielluong gabrielluong mentioned this pull request Nov 9, 2022
Closed
4 tasks
@mergify mergify bot merged commit df24580 into mozilla-mobile:main Nov 9, 2022
@gabrielluong gabrielluong deleted the color-copy-ci branch November 9, 2022 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonalmeida jonalmeida jonalmeida approved these changes

Assignees
No one assigned
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow FirefoxColors.copy to override some values
3 participants
@gabrielluong @jonalmeida @fice-t