Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #27338 - Update summary text for preferences from settings screen #28207

Merged
merged 2 commits into from Jan 18, 2023
Merged

For #27338 - Update summary text for preferences from settings screen #28207

merged 2 commits into from Jan 18, 2023

Conversation

Alexandru2909
Copy link
Contributor

@Alexandru2909 Alexandru2909 commented Dec 15, 2022 •
edited by github-actions bot

Updated summary text for preferences from settings screen according to document.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #27338

@Alexandru2909 Alexandru2909 requested review from a team as code owners December 15, 2022 07:49
@Alexandru2909 Alexandru2909 mentioned this pull request Dec 15, 2022
Closed
@gabrielluong gabrielluong self-assigned this Dec 15, 2022
t-p-white
t-p-white approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@t-p-white t-p-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes lgtm 👍

Mugurell
Mugurell reviewed Jan 18, 2023
View reviewed changes
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@Alexandru2909 Alexandru2909 added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Jan 18, 2023
@mergify mergify bot merged commit 769b6cf into mozilla-mobile:main Jan 18, 2023
@AndiAJ AndiAJ mentioned this pull request Jan 18, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mugurell Mugurell Mugurell left review comments

@t-p-white t-p-white t-p-white approved these changes

Assignees

@gabrielluong gabrielluong

Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show summary text for specified items in the top level settings view
4 participants
@Alexandru2909 @t-p-white @Mugurell @gabrielluong