Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Show summary text for specified items in the top level settings view #27338

Closed
fice-t opened this issue Oct 8, 2022 · 6 comments · Fixed by #28207
Closed

Show summary text for specified items in the top level settings view #27338

fice-t opened this issue Oct 8, 2022 · 6 comments · Fixed by #28207
Assignees
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage ux:replied tag to track needs-ux issues that have been responded to.
Milestone

Comments

@fice-t
Copy link
Contributor

fice-t commented Oct 8, 2022

Similar to the settings summary for Tabs (e.g. Close manually), the summaries for the above should also contain option selected.

e.g. For HTTPS-Only: On/Enable only in private tabs/Off
For ETP: On/Strict/Custom

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 8, 2022
fice-t added a commit to fice-t/fenix that referenced this issue Oct 8, 2022
fice-t added a commit to fice-t/fenix that referenced this issue Oct 8, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Oct 8, 2022
@Mugurell
Copy link
Contributor

Thank you for looking into this.
Please note that the UX is aligned between all platforms so any change in one app has a bigger impact and must be discussed with UX and product.
We might also need some new strings if wanting to offer more context about the current options.

Adding here also the video posted in the PR:

Device-2022-10-07-231420.mp4

@Mugurell Mugurell added the Needs-UX Issues or tickets that need UX input or review label Oct 10, 2022
@ewachowiak
Copy link

I'm looking into this issue and working on a solution that standardizes how we approach this across all settings, inclusive of iOS & Android. I opened a Jira task for this exploration: https://mozilla-hub.atlassian.net/browse/FXMUX-363

@ewachowiak
Copy link

To address the issue in this ticket, I took a more holistic look at how we use this "settings summary" content across settings on iOS & Android.

In this spreadsheet. I've outlined changes to the settings summaries, including where to update this content (blue copy) and where to add this content where it does not already exist today (red copy).

I'm requesting an updating to the scope of this ticket to include all of the proposed Android changes from the spreadsheet, which will resolve the original issue in this ticket and standardize our approach across settings. I'm opening a ticket on iOS to do the required work there.

Please reach out to me if there are any questions. This might be a great "first issue" for a community contributor, since it uses existing UI patterns.

FYI @cpeterso & @kbrosnan

@lime124 lime124 added ux:replied tag to track needs-ux issues that have been responded to. and removed Needs-UX Issues or tickets that need UX input or review labels Dec 5, 2022
@kbrosnan kbrosnan changed the title Summaries for Enhanced Tracking Protection and HTTPS-Only Mode should be more specific Show summary text for specified items in the top level settings view Dec 7, 2022
@Alexandru2909 Alexandru2909 self-assigned this Dec 12, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Dec 15, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Dec 15, 2022
@cpeterso
Copy link

@Alexandru2909 - You have a work-in-progress PR up for review. Do you think you will be able to land your fix during the Fenix Nightly 111 cycle? If so, I will leave this GitHub issue here. If not, then I will need to move it to Bugzilla (as we prepare to move the Fenix code to the new firefox-android monorepo).

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jan 18, 2023
@Alexandru2909
Copy link
Contributor

@cpeterso Thanks for checking! I'll land this during the 111 cycle.

@mergify mergify bot closed this as completed in #28207 Jan 18, 2023
@github-actions github-actions bot reopened this Jan 18, 2023
@github-actions github-actions bot added this to the 111 milestone Jan 18, 2023
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Jan 18, 2023
t-p-white pushed a commit to t-p-white/fenix that referenced this issue Jan 20, 2023
JohanLorenzo pushed a commit to mozilla-releng/staging-firefox-android that referenced this issue Jan 25, 2023
@delia-pop
Copy link

Verified as fixed on latest Nightly from 01/27 with Google Pixel 6 (Android 13). The summary text is displayed in accordance with the document above for each option.

summary

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage ux:replied tag to track needs-ux issues that have been responded to.
Projects
None yet
7 participants