Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5214 - Bumps expiration dates for telemetry #5216

Merged
merged 1 commit into from Sep 11, 2019

Conversation

boek
Copy link
Contributor

@boek boek commented Sep 11, 2019

No description provided.

@boek boek added the needs:data-review PR is awaiting a data review label Sep 11, 2019
@boek boek requested review from a team as code owners September 11, 2019 15:07
@boek
Copy link
Contributor Author

boek commented Sep 11, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often users use the different search engines bundled with Fenix
  • What other Mozilla owned products Fenix users have installed
  • What the landscape of which search engines users set as their default
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:
  • Establish baselines or measure changes in product or platform quality or performance.
  • We may want to surface different features to users who have certain Mozilla products installed like Lockbox, for example. It's also useful to know if users of Fenix have a different Mozilla browser set as their default so we can ensure our product is reaching a wide enough audience
  • We want to make sure that users are using the correct URL and other relevant search engine information
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A these are baseline metrics
  1. Can current instrumentation answer these questions?
  • No
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
A user performed a search Cat 2 #959
A list of all the Mozilla products installed on device Cat 2 #1192
A users default search engine Cat 1 #800
  1. How long will this data be collected? Choose one of the following:
  • Until re-evaluation 03-01-2020
  1. What populations will you measure?
  • Entire population
  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default on, opt out in settings.
  1. Please provide a general description of how you will analyze this data.
  • Using Glean/Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.
  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection? If so:
  • no

@codecov-io
Copy link

Codecov Report

Merging #5216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5216   +/-   ##
=========================================
  Coverage     11.55%   11.55%           
  Complexity      238      238           
=========================================
  Files           243      243           
  Lines          9784     9784           
  Branches       1415     1415           
=========================================
  Hits           1131     1131           
  Misses         8585     8585           
  Partials         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4485b7f...7e1947f. Read the comment docs.

@boek boek requested a review from liuche September 11, 2019 15:32
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, updating existing probes w/ documentation + data review here

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, Fenix data controls

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Fenix PM Vesta will monitor, and this has an expiry

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2, interaction with search UI, Type 1 for search w/ default search engine (bundled, not custom)

  1. Is the data collection request for default-on or default-off?

Default on

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No, telemetry expiration bump

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

Has expiry, 3/2020

  1. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No

@boek boek merged commit 215e66f into mozilla-mobile:master Sep 11, 2019
@boek boek deleted the i5214 branch September 11, 2019 21:44
@jyeontaek jyeontaek modified the milestone: v2.0 Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants