This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
[TEST] Raptor to Browsertime Migration #8780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
|
@mitchhentges, @JohanLorenzo do you know what I might be missing to have the raptor/browsertime tests run from this PR? It looks like I need to be added as a contributor. |
|
Hey Gregory! I confirm being a contributor is what you're missing. In the meantime, I can help you out by opening a new PR so you get to see them running. |
|
Hello @JohanLorenzo! That would be great, thank you. Would I be able to push updates to that PR or will a new PR need to be made for each update I make? |
mcarare
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8780 +/- ##
============================================
+ Coverage 18.74% 18.89% +0.15%
- Complexity 470 502 +32
============================================
Files 319 330 +11
Lines 12831 13061 +230
Branches 1691 1727 +36
============================================
+ Hits 2405 2468 +63
- Misses 10225 10384 +159
- Partials 201 209 +8
Continue to review full report at Codecov.
|
tomprince
added a commit
to tomprince/fenix
that referenced
this pull request
Mar 4, 2020
…tribute). The mozilla-central ffmpeg toolchain (used in Bug 1613479/mozilla-mobile#8780) has an artifact that does not start with `public/build/` (it starts with just `public/`). To easily support that, we want to set the `toolchain-artfiact` attribute for that task. We switched `index_search` to be a job-type in [taskgraph](https://hg.mozilla.org/ci/taskgraph/rev/932b4cf48cc785c31b03f0b9f2cba654bc67bc00) which pass through `attributes` from the task definition (and is also more future proof for adding fenix-specific toolchain tasks). This updates taskgraph and the consumers of the current toolchain.
tomprince
added a commit
to tomprince/fenix
that referenced
this pull request
Mar 4, 2020
…tribute). The mozilla-central ffmpeg toolchain (used in Bug 1613479/mozilla-mobile#8780) has an artifact that does not start with `public/build/` (it starts with just `public/`). To easily support that, we want to set the `toolchain-artfiact` attribute for that task. We switched `index_search` to be a job-type in [taskgraph](https://hg.mozilla.org/ci/taskgraph/rev/932b4cf48cc785c31b03f0b9f2cba654bc67bc00) which pass through `attributes` from the task definition (and is also more future proof for adding fenix-specific toolchain tasks). This updates taskgraph and the consumers of the current toolchain.
tomprince
added a commit
that referenced
this pull request
Mar 4, 2020
…tribute). The mozilla-central ffmpeg toolchain (used in Bug 1613479/#8780) has an artifact that does not start with `public/build/` (it starts with just `public/`). To easily support that, we want to set the `toolchain-artfiact` attribute for that task. We switched `index_search` to be a job-type in [taskgraph](https://hg.mozilla.org/ci/taskgraph/rev/932b4cf48cc785c31b03f0b9f2cba654bc67bc00) which pass through `attributes` from the task definition (and is also more future proof for adding fenix-specific toolchain tasks). This updates taskgraph and the consumers of the current toolchain.
tomprince
reviewed
Mar 13, 2020
| @@ -18,6 +18,8 @@ only-for-abis: | |||
| - arm64-v8a | |||
|
|
|||
| job-defaults: | |||
| attributes: | |||
| retrigger: true | |||
| dependencies: | |||
| geckoview-nightly: geckoview-nightly | |||
| linux64-minidump-stackwalk: toolchain-linux64-minidump-stackwalk | |||
There was a problem hiding this comment.
The dependency failure the prints seem to be trying to fix can be fixed by removing this line. I think this would be fixed if you rebase.
|
Merged in PR#9087. |
severinrudie
pushed a commit
to severinrudie/fenix
that referenced
this pull request
Mar 18, 2020
…tribute). The mozilla-central ffmpeg toolchain (used in Bug 1613479/mozilla-mobile#8780) has an artifact that does not start with `public/build/` (it starts with just `public/`). To easily support that, we want to set the `toolchain-artfiact` attribute for that task. We switched `index_search` to be a job-type in [taskgraph](https://hg.mozilla.org/ci/taskgraph/rev/932b4cf48cc785c31b03f0b9f2cba654bc67bc00) which pass through `attributes` from the task definition (and is also more future proof for adding fenix-specific toolchain tasks). This updates taskgraph and the consumers of the current toolchain.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for testing the migration from Raptor-webext to Raptor-browsertime.