Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #2271 - Fix hairline color on dark theme and private mode #8839

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

darkwing
Copy link
Contributor

@AmyYLee

Screenshot_20200227-232848
Screenshot_20200227-232819

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #8839 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8839   +/-   ##
=========================================
  Coverage     19.02%   19.02%           
  Complexity      490      490           
=========================================
  Files           320      320           
  Lines         12843    12843           
  Branches       1688     1688           
=========================================
  Hits           2443     2443           
  Misses        10196    10196           
  Partials        204      204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6cd105...dfb84a4. Read the comment docs.

@boek
Copy link
Contributor

boek commented Feb 28, 2020

Waiting on @AmyYLee to sign off

@darkwing
Copy link
Contributor Author

darkwing commented Mar 2, 2020

@AmyYLee Screenshot with updated hairline:

Screenshot_20200302-110420

@ekager ekager added the needs:UX-feedback Needs UX Feedback label Mar 2, 2020
@darkwing darkwing added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Mar 2, 2020
@AmyYLee
Copy link
Collaborator

AmyYLee commented Mar 2, 2020

@darkwing Hi, I've posted the hex for the hairline colours without opacity. Also the background colours for the search bar without opacity.

Screen Shot 2020-03-02 at 3 30 07 PM

@darkwing
Copy link
Contributor Author

darkwing commented Mar 2, 2020

OK, updated screenshots with new colors:

Screenshot_20200302-144525
Screenshot_20200302-144342
Screenshot_20200302-144122

@darkwing
Copy link
Contributor Author

darkwing commented Mar 2, 2020

Another update with new background colors:

Screenshot_20200302-152551
Screenshot_20200302-152518
Screenshot_20200302-152432

@AmyYLee
Copy link
Collaborator

AmyYLee commented Mar 2, 2020

@darkwing The above screenshots look good. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:UX-feedback Needs UX Feedback pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants