This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #2271 - Fix hairline color on dark theme and private mode #8839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8839 +/- ##
=========================================
Coverage 19.02% 19.02%
Complexity 490 490
=========================================
Files 320 320
Lines 12843 12843
Branches 1688 1688
=========================================
Hits 2443 2443
Misses 10196 10196
Partials 204 204 Continue to review full report at Codecov.
|
boek
approved these changes
Feb 28, 2020
Waiting on @AmyYLee to sign off |
@AmyYLee Screenshot with updated hairline: |
darkwing
added
the
pr:work-in-progress
PRs that are not ready to be reviewed yet and are actively being worked on
label
Mar 2, 2020
@darkwing Hi, I've posted the hex for the hairline colours without opacity. Also the background colours for the search bar without opacity. |
darkwing
force-pushed
the
2271-dark-hairline
branch
from
March 2, 2020 20:49
e0d2953
to
687f83d
Compare
darkwing
force-pushed
the
2271-dark-hairline
branch
from
March 2, 2020 21:23
687f83d
to
dfb84a4
Compare
@darkwing The above screenshots look good. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs:UX-feedback
Needs UX Feedback
pr:work-in-progress
PRs that are not ready to be reviewed yet and are actively being worked on
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AmyYLee
Pull Request checklist
After merge
To download an APK when reviewing a PR: