Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FXIOS-8779 - Login autofill not working on certain websites (backport #19490) #19501

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 2, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR:

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #19490 done by [Mergify](https://mergify.com).

* fix: simplify code and fix fill issues

* fix: yield focus back to field when bottomsheet is dismissed

(cherry picked from commit ed23f41)
@mergify mergify bot requested a review from a team as a code owner April 2, 2024 11:20
@mergify mergify bot requested review from mattreaganmozilla and removed request for a team April 2, 2024 11:20
@razvanlitianu razvanlitianu requested review from nbhasin2 and removed request for mattreaganmozilla April 2, 2024 12:25
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.67%
📖 Edited 4 files
📖 Created 0 files

Client.app: Coverage: 32.44

File Coverage
SelfSizingHostingController.swift 62.5%
CredentialAutofillCoordinator.swift 77.38%
LoginsHelper.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against ce98937

@dsmithpadilla dsmithpadilla merged commit 721ec9f into release/v124 Apr 2, 2024
11 of 12 checks passed
@dsmithpadilla dsmithpadilla deleted the mergify/bp/release/v124/pr-19490 branch April 2, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants