-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FXIOS-8779 - Login autofill not working on certain websites #19490
Fix FXIOS-8779 - Login autofill not working on certain websites #19490
Conversation
public static func yieldFocusBackToField(with tab: Tab) { | ||
let jsFocusCallback = "window.__firefox__.logins.yieldFocusBackToField()" | ||
tab.webView?.evaluateJavascriptInDefaultContentWorld(jsFocusCallback) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for FXIOS-8690. When we dismiss the bottom sheet we also want to yield focus back to the field and show the accessory view.
viewController.controllerWillDismiss = { [weak self] in | ||
guard let currentTab = self?.tabManager.selectedTab else { return } | ||
LoginsHelper.yieldFocusBackToField(with: currentTab) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@razvanlitianu to doublecheck
Client.app: Coverage: 32.26
Generated by 🚫 Danger Swift against b61bb91 |
Is this one going on 125? |
@afurlan-firefox yes @mergify backport release/v125 |
@mergify backport release/v125 |
✅ Backports have been created
|
* fix: simplify code and fix fill issues * fix: yield focus back to field when bottomsheet is dismissed (cherry picked from commit ed23f41)
@afurlan-firefox @nbhasin2 we have a recent issue that autofill does not work for 124.3, this can be a possible fix. Should we uplift? |
@mergify backport release/v124 |
✅ Backports have been created
|
* fix: simplify code and fix fill issues * fix: yield focus back to field when bottomsheet is dismissed (cherry picked from commit ed23f41)
…port #19490) (#19501) * Fix FXIOS-8779 - Login autofill not working on certain websites (#19490) * fix: simplify code and fix fill issues * fix: yield focus back to field when bottomsheet is dismissed (cherry picked from commit ed23f41) * Fix compile issue --------- Co-authored-by: Issam Mani <issamouu69@gmail.com> Co-authored-by: Razvan Litianu <litianu.razvan@gmail.com>
📜 Tickets
Jira ticket
Github issue
💡 Description
This PR:
focusin
event on capture since the page might cancel it.Use saved password
button is not displayed under certain steps #19276Netflix.com
even when having a username and password on the same webpage #19448📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)