Fix FXIOS-8779 - Login autofill not working on certain websites #19490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issammani
commented
Apr 1, 2024
Comment on lines
+341
to
+345
| public static func yieldFocusBackToField(with tab: Tab) { | ||
| let jsFocusCallback = "window.__firefox__.logins.yieldFocusBackToField()" | ||
| tab.webView?.evaluateJavascriptInDefaultContentWorld(jsFocusCallback) | ||
| } | ||
|
|
There was a problem hiding this comment.
This is for FXIOS-8690. When we dismiss the bottom sheet we also want to yield focus back to the field and show the accessory view.
nbhasin2
reviewed
Apr 1, 2024
Comment on lines
+158
to
+161
| viewController.controllerWillDismiss = { [weak self] in | ||
| guard let currentTab = self?.tabManager.selectedTab else { return } | ||
| LoginsHelper.yieldFocusBackToField(with: currentTab) | ||
| } |
There was a problem hiding this comment.
@razvanlitianu to doublecheck
nbhasin2
approved these changes
Apr 1, 2024
nbhasin2
changed the title
Client.app: Coverage: 32.26
Generated by 🚫 Danger Swift against b61bb91 |
|
Is this one going on 125? |
|
@afurlan-firefox yes @mergify backport release/v125 |
razvanlitianu
approved these changes
Apr 2, 2024
|
@mergify backport release/v125 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
* fix: simplify code and fix fill issues * fix: yield focus back to field when bottomsheet is dismissed (cherry picked from commit ed23f41)
6 tasks
|
@afurlan-firefox @nbhasin2 we have a recent issue that autofill does not work for 124.3, this can be a possible fix. Should we uplift? |
|
@mergify backport release/v124 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
* fix: simplify code and fix fill issues * fix: yield focus back to field when bottomsheet is dismissed (cherry picked from commit ed23f41)
6 tasks
dsmithpadilla
pushed a commit
that referenced
this pull request
Apr 2, 2024
…port #19490) (#19501) * Fix FXIOS-8779 - Login autofill not working on certain websites (#19490) * fix: simplify code and fix fill issues * fix: yield focus back to field when bottomsheet is dismissed (cherry picked from commit ed23f41) * Fix compile issue --------- Co-authored-by: Issam Mani <issamouu69@gmail.com> Co-authored-by: Razvan Litianu <litianu.razvan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This PR:
focusinevent on capture since the page might cancel it.Use saved passwordbutton is not displayed under certain steps #19276Netflix.comeven when having a username and password on the same webpage #19448📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)