Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FXIOS-9088 - Remove Pocket Share Sheet Experiment #20173

Merged
merged 3 commits into from
May 9, 2024
Merged

Remove FXIOS-9088 - Remove Pocket Share Sheet Experiment #20173

merged 3 commits into from
May 9, 2024

Conversation

dataports
Copy link
Contributor

@dataports dataports commented May 8, 2024 •
edited

📜 Tickets

Jira ticket
Github issue

💡 Description

Removes Pocket share sheet experiment which effected the context menu options when long pressing items in the the tab tray, and whether the share to device menu appears in the Settings menu.
Removed code for enabling the share button in the toolbar.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dataports dataports requested a review from a team as a code owner May 8, 2024 00:13
dataports
dataports commented May 8, 2024
View reviewed changes
firefox-ios/Client/Frontend/Share/ShareExtensionHelper.swift
}

/// Exclude 'Add to Reading List' which currently uses Safari. If share sheet changes are enabled exclude
/// Copy from system to provide custom activity
Copy link
Contributor Author

@dataports dataports May 8, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adudenamedruby this comment was not clear to me so I removed it lol, but I think the logic below is right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is not clear to me either. Did I write it? lololol Logic looks fine to me, though, yeah.

@dataports
Copy link
Contributor Author

@adudenamedruby tagged you on this one because you're the Nimbus KingTM and this is my first PR touching feature flags. I feel like there's a file I need to remove somewhere that I'm forgetting about but not sure...

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented May 8, 2024 •
edited

Messages
📖 Project coverage: 32.62%
📖 Edited 6 files
📖 Created 0 files

Client.app: Coverage: 31.23

File Coverage
MainMenuActionHelper.swift 41.49% ⚠️
ShareExtensionHelper.swift 77.94% ✅
TabLocationView.swift 41.67% ⚠️
NimbusFlaggableFeature.swift 97.75% ✅
NimbusFeatureFlagLayer.swift 74.88% ✅

Generated by 🚫 Danger Swift against 705fcb8

adudenamedruby
adudenamedruby requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@adudenamedruby adudenamedruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halmost there. Just more delets needed. Moar. MOAR!

firefox-ios/Client/Frontend/Share/ShareExtensionHelper.swift
}

/// Exclude 'Add to Reading List' which currently uses Safari. If share sheet changes are enabled exclude
/// Copy from system to provide custom activity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is not clear to me either. Did I write it? lololol Logic looks fine to me, though, yeah.

firefox-ios/Client/Nimbus/NimbusFeatureFlagLayer.swift Show resolved Hide resolved
@dataports dataports force-pushed the sa/fxios-9088_remove-pocket-share-experiment branch from dd4060a to 8797dde Compare May 8, 2024 22:55
@dataports
Copy link
Contributor Author

Halmost there. Just more delets needed. Moar. MOAR!

Ready for another look!

@dataports
Copy link
Contributor Author

@adudenamedruby Also please see recent commit where I just took out the share button from the toolbar completely - double checked today and we weren't using it outside of this experiment so thought I would just remove it all.

@dataports dataports closed this May 8, 2024
@dataports dataports reopened this May 8, 2024
adudenamedruby
adudenamedruby approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@adudenamedruby adudenamedruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dataports dataports force-pushed the sa/fxios-9088_remove-pocket-share-experiment branch from 278380c to 705fcb8 Compare May 9, 2024 15:16
@dataports dataports merged commit a6329c8 into main May 9, 2024
10 checks passed
@dataports dataports deleted the sa/fxios-9088_remove-pocket-share-experiment branch May 9, 2024 15:42
@dataports dataports added the weekly-release Tagging backports for rapid release label May 9, 2024
@data-sync-user data-sync-user mentioned this pull request May 10, 2024
Open
@dataports
Copy link
Contributor Author

@Mergifyio backport release/v126

@dataports dataports removed the weekly-release Tagging backports for rapid release label May 14, 2024
@DonalMe
Copy link
Contributor

DonalMe commented May 16, 2024

@dataports looks like a backport was not created for some reason. Not sure why, your comment was correct.
It's worth investigating why it didn't work for you. (permission, mergify outage at the time, something else)
I'll do it for you so we have it ready to go.

@DonalMe
Copy link
Contributor

DonalMe commented May 16, 2024

@Mergifyio backport release/v126

@mergify Mergify
Copy link
Contributor

mergify bot commented May 16, 2024 •
edited

backport release/v126

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 16, 2024
@dataports @mergify
Remove FXIOS-9088 - Remove Pocket Share Sheet Experiment (#20173)
25acd6b 
(cherry picked from commit a6329c8)
@mergify mergify bot mentioned this pull request May 16, 2024
Merged
6 tasks
DonalMe pushed a commit that referenced this pull request May 24, 2024
@mergify @dataports
Remove FXIOS-9088 - Remove Pocket Share Sheet Experiment (#20173) (#2…
0e64e75 
…0283)

(cherry picked from commit a6329c8)

Co-authored-by: Sophie <5545720+dataports@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adudenamedruby adudenamedruby adudenamedruby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dataports @mobiletest-ci-bot @DonalMe @adudenamedruby