Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FXIOS-9088 - Remove Pocket Share Sheet Experiment (backport #20173) #20283

Merged
merged 1 commit into from
May 24, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 16, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Removes Pocket share sheet experiment which effected the context menu options when long pressing items in the the tab tray, and whether the share to device menu appears in the Settings menu.
Removed code for enabling the share button in the toolbar.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #20173 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner May 16, 2024 12:42
@mergify mergify bot requested review from cyndichin and removed request for a team May 16, 2024 12:42
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.24%
📖 Edited 6 files
📖 Created 0 files

Client.app: Coverage: 30.78

File Coverage
MainMenuActionHelper.swift 41.6% ⚠️
ShareExtensionHelper.swift 77.94%
TabLocationView.swift 41.56% ⚠️
NimbusFlaggableFeature.swift 97.73%
NimbusFeatureFlagLayer.swift 76.88%

Generated by 🚫 Danger Swift against 25acd6b

@cyndichin cyndichin requested review from dataports and removed request for cyndichin May 16, 2024 14:29
@dataports dataports added the weekly-release Tagging backports for rapid release label May 16, 2024
@DonalMe
Copy link
Contributor

DonalMe commented May 17, 2024

This is currently planned to ship with 126.2

Copy link
Contributor

@DonalMe DonalMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 126.2

@DonalMe DonalMe merged commit 0e64e75 into release/v126 May 24, 2024
12 checks passed
@DonalMe DonalMe deleted the mergify/bp/release/v126/pr-20173 branch May 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
weekly-release Tagging backports for rapid release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants