Skip to content

Commit

Permalink
remove nested go.mod for verifier/contentsignature
Browse files Browse the repository at this point in the history
This was causing surprises for devs making changes
in that package and hitting a variety of build
problems when they realized they hadn't updated
the top-level go.mod. And other hacks failed to be
kept up (see
#896 (comment) ).

The only external user of
verifier/contentsignature was the
mozilla-vpn-client and @oskirby (a maintainer of
it) tells us they've been using a rust version for
a while now. Clients also could just use the
autograph repo's versioning instead.

Can be confirmed with this search:
https://github.com/search?q=autograph%2Fverifier%2Fcontentsignature&type=code
  • Loading branch information
jmhodges committed May 2, 2024
1 parent 4cba2b9 commit 12dd349
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ require (
github.com/mattn/go-colorable v0.1.4 // indirect
github.com/mattn/go-isatty v0.0.10 // indirect
github.com/miekg/pkcs11 v1.0.3
github.com/mozilla-services/autograph/verifier/contentsignature v0.0.0-00010101000000-000000000000
github.com/mozilla-services/yaml v0.0.0-20191106225358-5c216288813c
github.com/sirupsen/logrus v1.8.1
github.com/youtube/vitess v2.1.1+incompatible // indirect
Expand Down
1 change: 0 additions & 1 deletion vendor/github.com/mozilla-services/autograph/verifier

This file was deleted.

3 changes: 0 additions & 3 deletions vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,6 @@ github.com/miekg/pkcs11
github.com/mitchellh/go-homedir
# github.com/mitchellh/go-wordwrap v1.0.0
github.com/mitchellh/go-wordwrap
# github.com/mozilla-services/autograph/verifier/contentsignature v0.0.0-00010101000000-000000000000 => ./verifier/contentsignature/
## explicit
github.com/mozilla-services/autograph/verifier/contentsignature
# github.com/mozilla-services/yaml v0.0.0-20191106225358-5c216288813c
## explicit
github.com/mozilla-services/yaml
Expand Down
3 changes: 0 additions & 3 deletions verifier/contentsignature/go.mod

This file was deleted.

Empty file removed verifier/contentsignature/go.sum
Empty file.

0 comments on commit 12dd349

Please sign in to comment.