Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signer: remove MD5 hashes from XPI manifest entires and sig files #142

Merged
merged 1 commit into from
Sep 19, 2018
Merged

signer: remove MD5 hashes from XPI manifest entires and sig files #142

merged 1 commit into from
Sep 19, 2018

Conversation

g-k
Copy link
Contributor

@g-k g-k commented Sep 19, 2018

Per email thread with dveditz, these only applied to "ancient
pre-legacy add-on signing" and are now bloat.

reverts:

#121
#128

r? @jvehent

signer: remove MD5 hashes from XPI manifest entires and sig files
98a43f9 
Per email thread with dveditz, these only applied to "ancient
pre-legacy add-on signing" and are now bloat.

reverts:

#121
#128
@g-k g-k requested a review from jvehent September 19, 2018 17:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 957

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 81.305%
Totals Coverage Status
Change from base Build 954: -0.08%
Covered Lines: 1770
Relevant Lines: 2177
💛 - Coveralls

jvehent
jvehent approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@jvehent jvehent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

called it...

@g-k
Copy link
Contributor Author

g-k commented Sep 19, 2018

But I learned something along the way

@g-k g-k merged commit c609283 into master Sep 19, 2018
@g-k g-k deleted the rm-xpi-md5 branch September 19, 2018 17:29
@g-k g-k mentioned this pull request Jan 25, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvehent jvehent jvehent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-k @coveralls @jvehent