remove nested go.mod for verifier/contentsignature #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing surprises for devs making changes in that package and hitting a variety of build problems when they realized they hadn't updated the top-level go.mod. And other hacks failed to be kept up (see #896 (comment) ). The only external user of verifier/contentsignature was the mozilla-vpn-client and @oskirby (a maintainer of it) tells us they've been using a rust version for a while now. Clients also could just use the autograph repo's versioning instead. Can be confirmed with this search: https://github.com/search?q=autograph%2Fverifier%2Fcontentsignature&type=code
Pull Request Test Coverage Report for Build 11108Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing surprises for devs making changes
in that package and hitting a variety of build
problems when they realized they hadn't updated
the top-level go.mod. And other hacks failed to be
kept up (see
#896 (comment) ).
The only external user of
verifier/contentsignature was the
mozilla-vpn-client and @oskirby (a maintainer of
it) tells us they've been using a rust version for
a while now. Clients also could just use the
autograph repo's versioning instead.
Can be confirmed with this search:
https://github.com/search?q=autograph%2Fverifier%2Fcontentsignature&type=code