Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Fix bug with version defaulting to 0 #395

Closed
bbangert opened this issue Mar 9, 2016 · 1 comment
Closed

Fix bug with version defaulting to 0 #395

bbangert opened this issue Mar 9, 2016 · 1 comment
Assignees
@bbangert
Labels
bug
Milestone
PUSHSVC-0: quality

Comments

@bbangert
Copy link
Member

bbangert commented Mar 9, 2016

cyclone defaults to None being passed in for missing params, this should be accounted for in the handlers.
@bbangert bbangert self-assigned this Mar 9, 2016
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Mar 9, 2016
@jrconlin
Copy link
Member

In addition: there needs to be testing to ensure that the UAID and CHID being provided are not being corrupted before being referenced by storage.

We had a problem where '123' was being corrupted into a valid UUID like entity in some tests this produced false positive testing instead of flagging the value as being incorrect.

bbangert added a commit that referenced this issue Mar 10, 2016
@bbangert
fix: default api_ver to v0 for message endpoint
0b8deb0 
Default the api_ver to v0 for the message endpoint. Previously a
value of None could pass in causing earlier endpoints to be incorrectly
parsed out. parse_endpoint now throws InvalidTokenExceptions to avoid
being caught on accident as a ValueError.

Closes #395
bbangert added a commit that referenced this issue Mar 10, 2016
@bbangert
fix: default api_ver to v0 for message endpoint
86ba66d 
Default the api_ver to v0 for the message endpoint. Previously a
value of None could pass in causing earlier endpoints to be incorrectly
parsed out. parse_endpoint now throws InvalidTokenExceptions to avoid
being caught on accident as a ValueError.

Closes #395
@bbangert bbangert mentioned this issue Mar 10, 2016
Merged
jrconlin pushed a commit that referenced this issue Mar 12, 2016
@bbangert @jrconlin
fix: default api_ver to v0 for message endpoint
04b221c 
Default the api_ver to v0 for the message endpoint. Previously a
value of None could pass in causing earlier endpoints to be incorrectly
parsed out. parse_endpoint now throws InvalidTokenExceptions to avoid
being caught on accident as a ValueError.

Closes #395
jrconlin pushed a commit that referenced this issue Mar 12, 2016
@bbangert @jrconlin
fix: default api_ver to v0 for message endpoint
1dd39e1 
Default the api_ver to v0 for the message endpoint. Previously a
value of None could pass in causing earlier endpoints to be incorrectly
parsed out. parse_endpoint now throws InvalidTokenExceptions to avoid
being caught on accident as a ValueError.

Closes #395
jrconlin pushed a commit that referenced this issue Mar 15, 2016
@bbangert @jrconlin
fix: default api_ver to v0 for message endpoint
dfb557d 
Default the api_ver to v0 for the message endpoint. Previously a
value of None could pass in causing earlier endpoints to be incorrectly
parsed out. parse_endpoint now throws InvalidTokenExceptions to avoid
being caught on accident as a ValueError.

Closes #395
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
bug
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
2 participants
@jrconlin @bbangert