This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: include crypto-key when routing & storing messages #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ |
bbangert
added a commit
that referenced
this pull request
Feb 22, 2016
bug: include crypto-key when routing & storing messages
| # they're present to avoid empty strings. | ||
| for name in ["encryption-key", "crypto-key"]: | ||
| if name in headers: | ||
| data[name] = headers[name] |
There was a problem hiding this comment.
Perhaps should it be modified to data[name.replace('-', '_')] = headers[name]?
There was a problem hiding this comment.
The - to _ is more for logs than for data exchange. These values need to stay consistent between routing and eventual delivery to clients. Changing these values here could break dependency outside of the app.
Still, nice spotting. Thanks!
There was a problem hiding this comment.
@tomoyukilabs You actually spotted a bug. As currently written, this will break data delivery for all clients. Thanks for catching that, and your comment on Bugzilla! 👀 I'll send a PR soon.
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #355
@bbangert r?