This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: avoid uaid error in webpush preflight #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +64,7 @@ def register(self, uaid, connect, *kwargs): | |||
| def amend_msg(self, msg, router_data=None): | |||
| return msg | |||
|
|
|||
| def preflight_check(self, uaid, channel_id): | |||
| def preflight_check(self, uaid_data, channel_id): | |||
|
+r Really wonder if it might be worth auditing parameters to see where we can simplify to the dict. |
Current coverage is 100% (diff: 100%)@@ master #566 diff @@
====================================
Files 42 42
Lines 8752 8753 +1
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 8752 8753 +1
Misses 0 0
Partials 0 0
|
| if month_table not in self.ap_settings.message_tables: | ||
| self.log.info("'current_month' out of scope: {record}", | ||
| records=json.dumps(record)) | ||
| records=json.dumps(uaid_data)) |
There was a problem hiding this comment.
While you're here, records= is broken (per {record}) -- maybe change it to uaid instead (if so, "UAID missing .." above too)? channelid= a few lines below is also broken
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the uaid error on fetch in the preflight by re-using the existing fetched
data. If the current_month doesn't exist, this is an invalid record so the uaid
is removed as it should've been.
closes #542, #553
@jrconlin, @pjenvey r?