Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the sandbox size to size_t #91

Closed
trink opened this issue Jul 13, 2015 · 3 comments
Closed

Change the sandbox size to size_t #91

trink opened this issue Jul 13, 2015 · 3 comments

Comments

@trink
Copy link
Contributor

trink commented Jul 13, 2015

Currently the size is stored in an unsigned int but after removing the size restriction this can now be overflowed.
@trink
Copy link
Contributor Author

trink commented Jul 13, 2015

sigh, this would mean changing the LuaJIT internals too

@trink
Copy link
Contributor Author

trink commented Sep 29, 2015

considering just enforcing a limit of UINT_MAX

@trink
Copy link
Contributor Author

trink commented Feb 5, 2016

After considering different options the size is now restricted to INT_MAX by the configuration since this has been tested, is consistent between setups and proven stable/usable. Internally it is larger so if we decide to expand it in the future there will be less pain.

@trink trink closed this as completed Feb 5, 2016
@trink trink mentioned this issue Feb 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trink