This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
bug: avoid overwriting without suitable window precedent #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overwriting the DAU/MAU values with new ones with insufficient leading values results in proper window averages not being recorded after time. This remedies that by skipping the added preceeding rows in the update.
bbangert
force-pushed
the
bug/avoid_overwriting_too_recent
branch
from
e3d0c8e
to
10217e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overwriting the DAU/MAU values with new ones with insufficient
leading values results in proper window averages not being
recorded after time. This remedies that by skipping the added
preceeding rows in the update.
@rafrombrc r?