Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create precondition header middleware #78

Closed
bbangert opened this issue Nov 2, 2018 · 0 comments
Closed

Create precondition header middleware #78

bbangert opened this issue Nov 2, 2018 · 0 comments
Assignees
@bbangert

Comments

@bbangert
Copy link
Member

bbangert commented Nov 2, 2018

To avoid doing queries we shouldn't, the precondition header check should be done in middleware in front of the db middlware, to verify whether the query has any chance of succeeding.
@bbangert bbangert mentioned this issue Nov 2, 2018
Closed
12 tasks
@bbangert bbangert added the to do label Nov 2, 2018
@bbangert bbangert self-assigned this Nov 2, 2018
@bbangert bbangert added in progress and removed to do labels Nov 2, 2018
@bbangert bbangert mentioned this issue Nov 9, 2018
Merged
bbangert added a commit that referenced this issue Nov 10, 2018
@bbangert
feat: add precondition check middleware and handler headers
b066fba 
Most handler functions now have the appropriate header added. The
precondition middleware returns the request early if the modified
header and database differ.

Closes #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbangert bbangert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjenvey @bbangert