feat: add path uid validation to HawkIdentifier extractor #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbangert
force-pushed
the
feat/issue-48.1
branch
5 times, most recently
from
e88f640
to
7528798
Compare
Per extract_target_resource extraction from the Python version, this add's uid validation to the HawkIdentifier extraction. Issue #48
bbangert
force-pushed
the
feat/issue-48.1
branch
from
7528798
to
b4423c2
Compare
rfk
approved these changes
Oct 15, 2018
| format!("services.mozilla.com/tokenlib/v1/derive/{}", id).as_bytes(), | ||
| Some(salt.as_bytes()), | ||
| &SECRETS.master_secret, | ||
| ); |
There was a problem hiding this comment.
It feels like you should be able to import some higher-level function to do this, rather than duplicating all the details of how to make a token into the test here.
There was a problem hiding this comment.
Indeed, I didn't find any function that would do it though. I'll probably move this out to be that higher level function elsewhere.
| let payload = HawkPayload { | ||
| expires: Utc::now().timestamp() as f64 + 200000.0, | ||
| node: "friendly-node".to_string(), | ||
| salt: "saltysalt".to_string(), |
| .header("authorization", header) | ||
| .method(Method::GET) | ||
| .uri("http://localhost:5000/storage/1.5/5/storage/col2") | ||
| .param("uid", "5") |
There was a problem hiding this comment.
Do you have to repeat the 5 here because TestRequest won't parse the uid out of the supplised URI?
There was a problem hiding this comment.
Yup, TestRequest assumes the params were parsed by the Server and put in the the params object on the request.
philbooth
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per extract_target_resource extraction from the Python version, this
add's uid validation to the HawkIdentifier extraction.
Issue #48