Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port default validators #48

Closed
bbangert opened this issue Oct 5, 2018 · 1 comment
Closed

Port default validators #48

bbangert opened this issue Oct 5, 2018 · 1 comment

Comments

@bbangert
Copy link
Member

bbangert commented Oct 5, 2018

The default validators from Python:

DEFAULT_VALIDATORS = (
    extract_target_resource,
    extract_precondition_headers,
    extract_query_params,
)

Issue #29's last PR brought over extract_query_params and the machinery needed. Closing this requires implementing the other 2 default validators.
@bbangert bbangert mentioned this issue Oct 9, 2018
Closed
12 tasks
@bbangert bbangert mentioned this issue Oct 12, 2018
Merged
bbangert added a commit that referenced this issue Oct 12, 2018
@bbangert
feat: add a precondition header validator/extractor
dfe1025 
Issue #48
@bbangert bbangert mentioned this issue Oct 13, 2018
Merged
bbangert added a commit that referenced this issue Oct 13, 2018
@bbangert
feat: add path uid validation to HawkIdentifier extractor
b4423c2 
Per extract_target_resource extraction from the Python version, this
add's uid validation to the HawkIdentifier extraction.

Issue #48
@bbangert
Copy link
Member Author

I'm considering this closed by the last one, as the collection/item extraction done in one of the prior default validators is not ideal for Rust. It's better to require it when needed for the endpoints, so I'll integrate that into the validator/extractor for handlers that need the collection/item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbangert