Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #266 #862

Merged
merged 2 commits into from
Nov 4, 2019
Merged

fixes #266 #862

merged 2 commits into from
Nov 4, 2019

Conversation

ankiiitraj
Copy link
Contributor

Registering ESC keydown to hide the required block.

@ankiiitraj
Copy link
Contributor Author

Hi @Rob--W, I have tested the changes and it is working fine. Now there is no lags in the page. Can you please assign yourself as the Reviewer. Thanks.

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! This looks much cleaner than a componentDidMount-based approach!

@Rob--W Rob--W merged commit 27750a5 into mozilla:master Nov 4, 2019
@caitmuenster
Copy link
Contributor

Woohoo! Thank you, @ankiiitraj! Your contribution has been added to our recognition wiki.

Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants