#942 preview theme #945
#942 preview theme #945
Conversation
andreicristianpetcu
changed the title
There was a problem hiding this comment.
Huh nice fix, I didn't even notice it.
What I did notice is that the red dashes are visible when the "Popup Background" is partially transparent. Previously the opaque color of the .browser-popup__caret element would be in front of the outline of the popup, and consequently the triangle would visually appear to be attached to the popup.
Do you have more CSS-magic up your sleeve to fix that? If not then I'll proceed with merging it as is.
|
So you want the dashes to have the same color as the popup? When it's transparent, so should the dashes, right? |
|
There is not an issue with the transparency of the red dashes - them being opaque is fine, as they only appear when the user selects a color. I think that my previous comment wasn't clear, so I'll try to be a bit more detailed below. The (minor) issue is that there are visible dashes at the intersection of the triangle and the rectangle (from the outline around the rectangle). You can also see this in your screenshot, look near the extrusion at the popup. You'll see dashes (which are painted behind the triangle):
|
|
I looked into the issue with the border and it seems very complicated. I think it can be done with a really complicated clip path but I'm not sure it's worth my time. If it's ok with you, I say merge it as it is and release it. @Rob--W |
#942 (comment)