Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ESLint rule react/sort-comp globally #11933

Closed
willdurand opened this issue Jun 21, 2018 · 2 comments · Fixed by mozilla/addons-frontend#5361
Closed

Disable ESLint rule react/sort-comp globally #11933

willdurand opened this issue Jun 21, 2018 · 2 comments · Fixed by mozilla/addons-frontend#5361

Comments

@willdurand
Copy link
Member

The react/sort-comp rule often forces us to either disable it or to write code we did not want to write in the first place (for example, adding attribute declarations in the middle of a class, not at the top of it).

We should disable this rule globally.

@muffinresearch
Copy link
Contributor

@willdurand can this also be ported to eslint-config-amo?

@willdurand
Copy link
Member Author

I was hesitant because maybe it was addons-frontend specific, but sure, I will do that!

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants