Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare JS files against hash whitelist #383

Closed
tofumatt opened this issue Dec 4, 2015 · 0 comments
Closed

Compare JS files against hash whitelist #383

tofumatt opened this issue Dec 4, 2015 · 0 comments
Assignees
@tofumatt

Comments

@tofumatt
Copy link
Contributor

tofumatt commented Dec 4, 2015

First step to #66 is to compare all JS files against a collection of known JS libs. We're using hashes the same way the old validator did it, as it seems the sane way to go about it.
@tofumatt tofumatt self-assigned this Dec 4, 2015
@muffinresearch muffinresearch mentioned this issue Dec 4, 2015
Closed
3 tasks
tofumatt added a commit that referenced this issue Dec 4, 2015
@tofumatt
Compare JS files against known JS libs (fix #383)
127c275 
Part of #66, this checks all JS files against a hash of known JS
libraries.

We're borrowing the current list from the old [amo-validator](https://github.com/mozilla/amo-validator/blob/master/validator/testcases/hashes.txt)
but in the future (#384) we'll have our own list.

Named filehasher and avoiding the name whitelist because of @andymckay's
[thoughtful blog post](http://mckay.pub/2015-01-07-allowed/).
tofumatt added a commit that referenced this issue Dec 4, 2015
@tofumatt
Merge pull request #385 from mozilla/check-for-known-js-libs-383
d4f6600 
Compare JS files against known JS libs (fix #383)
This was referenced Nov 23, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tofumatt