Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build our own list of JS libs #384

Closed
tofumatt opened this issue Dec 4, 2015 · 3 comments
Closed

Build our own list of JS libs #384

tofumatt opened this issue Dec 4, 2015 · 3 comments
Assignees
@tofumatt

Comments

@tofumatt
Copy link
Contributor

tofumatt commented Dec 4, 2015

We should have a node way of building the JS lib hashes.

@muffinresearch and I talked about this and the whitelist might make sense as a separate repo we could:

  • update independently
  • share with others
@tofumatt tofumatt added the 45.3 label Dec 4, 2015
@tofumatt tofumatt self-assigned this Dec 4, 2015
@muffinresearch muffinresearch mentioned this issue Dec 4, 2015
Closed
3 tasks
tofumatt added a commit that referenced this issue Dec 4, 2015
@tofumatt
Compare JS files against known JS libs (fix #383)
127c275 
Part of #66, this checks all JS files against a hash of known JS
libraries.

We're borrowing the current list from the old [amo-validator](https://github.com/mozilla/amo-validator/blob/master/validator/testcases/hashes.txt)
but in the future (#384) we'll have our own list.

Named filehasher and avoiding the name whitelist because of @andymckay's
[thoughtful blog post](http://mckay.pub/2015-01-07-allowed/).
@tofumatt tofumatt mentioned this issue Dec 4, 2015
Merged
tofumatt added a commit that referenced this issue Dec 4, 2015
@tofumatt
Compare JS files against known JS libs (fix #383)
722351b 
Part of #66, this checks all JS files against a hash of known JS
libraries.

We're borrowing the current list from the old [amo-validator](https://github.com/mozilla/amo-validator/blob/master/validator/testcases/hashes.txt)
but in the future (#384) we'll have our own list.

Named filehasher and avoiding the name whitelist because of @andymckay's
[thoughtful blog post](http://mckay.pub/2015-01-07-allowed/).
@tofumatt
Copy link
Contributor Author

tofumatt commented Dec 5, 2015

In progress at https://github.com/mozilla/dispensary

@andymckay andymckay added 46.2 and removed 46.1 labels Jan 5, 2016
@tofumatt
Copy link
Contributor Author

Complete.

@tofumatt
Copy link
Contributor Author

We had a version on NPM at mozilla/dispensary@c98fb2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andymckay @tofumatt @andymckay-limited-access