Compare JS files against known JS libs (fix #383) #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yep exactly - just showing that a non-matching file isn't in the list. |
|
r+wc |
Part of #66, this checks all JS files against a hash of known JS libraries. We're borrowing the current list from the old [amo-validator](https://github.com/mozilla/amo-validator/blob/master/validator/testcases/hashes.txt) but in the future (#384) we'll have our own list. Named filehasher and avoiding the name whitelist because of @andymckay's [thoughtful blog post](http://mckay.pub/2015-01-07-allowed/).
tofumatt
force-pushed
the
check-for-known-js-libs-383
branch
from
127c275 to
722351b
Compare
tofumatt
added a commit
that referenced
this pull request
Dec 4, 2015
Compare JS files against known JS libs (fix #383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #66, this checks all JS files against a hash of known JS
libraries.
We're borrowing the current list from the old amo-validator
but in the future (#384) we'll have our own list.
Named filehasher and avoiding the name whitelist because of @andymckay's
thoughtful blog post.