Update addons-linter to 0.1.0 #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EnTeQuAk
commented
Apr 27, 2016
EnTeQuAk
commented
- Forward listed / unlisted to addons-linter (fixes Forward listed/unlisted to addons-linter addons#2659)
- Update tests to represent corrected id behavior in addons-linter
* Forward listed / unlisted to addons-linter (fixes #1910) * Update tests to represent corrected id behavior in addons-linter
| result = tasks.validate_file_path( | ||
| get_addon_file('invalid_webextension_missing_id.xpi'), | ||
| get_addon_file('invalid_webextension_invalid_id.xpi'), |
There was a problem hiding this comment.
We validate IDs but don't require them. Should we at least file a bug to move this into the linter? (Or maybe it already does so)
There was a problem hiding this comment.
The linter does everything correct. This test is based on the idea that addons-linter actually validates the id for a webextension and amo-validator doesn't so I'm using that to not just test "did I call this?" but also to verify that we get something expected back from the linter.
There was a problem hiding this comment.
ah okay cool. All good then!
|
r+wc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.